Bug 185824
Summary: | Review Request: perl-Date-Pcalc - Gregorian calendar date calculations | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mike McGrath <imlinux> |
Component: | Package Review | Assignee: | Miloslav Trmač <mitr> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-03-20 16:59:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 180015 |
Description
Mike McGrath
2006-03-18 20:54:10 UTC
Looks good, only a few things: - The tarball contains licence texts, so they must be packaged - Please convert the man page from ISO-8859-1 to UTF-8: W: perl-Date-Pcalc file-not-utf8 /usr/share/man/man3/Date::Pcalc.3pm.gz - Consider packaging CREDITS.txt; README.txt refers to it and the authors deserve the credit. Spec: http://mmcgrath.net/~mmcgrath/perl-Date-Pcalc/perl-Date-Pcalc.spec SRMP: http://mmcgrath.net/~mmcgrath/perl-Date-Pcalc/perl-Date-Pcalc-1.2-2.src.rpm %changelog - Include license and credits - Convert manpage to utf-8 Nitpicks: - This comment is now obsolete: # For license text(s), see the perl package. - It is not necessary to quote : as \: in shell commands Approved. Built in devel successfuly. |