Bug 1858326

Summary:	avoid warning trying to set "active_slave" bond option when activating master
Product:	Red Hat Enterprise Linux 8	Reporter:	Thomas Haller <thaller>
Component:	NetworkManager	Assignee:	Thomas Haller <thaller>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.2	CC:	acardace, atragler, bgalvani, lrintel, rkhan, sukulkar, thaller, till, vbenes
Target Milestone:	rc
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	NetworkManager-1.26.0-2.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-04 01:47:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Thomas Haller 2020-07-17 14:27:19 UTC

the sysctl values "activate_slave" for bond can only be set if the slave interface is actually enslaved. Otherwise, kernel logs a warning. Also, writing the sysctl will fail, and NetworkManager also logs a warning.

Avoid that.


Backport https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/e48c908e8cb5e0b426a4bf8d99608f73cd7890e4 to rhel-8.3

Comment 1 Thomas Haller 2020-07-17 14:33:01 UTC

reproduce: on "1.26.0-1", activate a bond master that has "active_slave" option set.

- Note the warning in the logs. The only problem is that NM tries to do something that it shouldn't and that doesn't work. That causes error messages in log.

- also note, that if you later activate the slave, the "active_slave" option gets set. But that is unrelated to this issue, and we should have CI for that already.

Comment 2 Thomas Haller 2020-07-17 14:33:54 UTC

I don't think this requires a dedicated CI test. We already have CI tests for various bond-cases, including "active_slave" (don't we?).

Comment 5 Vladimir Benes 2020-07-23 19:45:18 UTC

(In reply to Thomas Haller from comment #2)
> I don't think this requires a dedicated CI test. We already have CI tests
> for various bond-cases, including "active_slave" (don't we?).

yeah we have one 
bond_set_active_backup_options

https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/blob/master/nmcli/features/bond.feature#L1184

CI test modified to catch the error now
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/611

Comment 8 errata-xmlrpc 2020-11-04 01:47:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (NetworkManager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4499