Bug 1858363

Summary:	VDO ignores flush errors
Product:	Red Hat Enterprise Linux 8	Reporter:	Sweet Tea Dorminy <sweettea>
Component:	kmod-kvdo	Assignee:	Sweet Tea Dorminy <sweettea>
Status:	CLOSED ERRATA	QA Contact:	Filip Suba <fsuba>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.0	CC:	awalsh
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	6.2.3.113	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-04 02:01:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sweet Tea Dorminy 2020-07-17 16:45:41 UTC

Description of problem:
If the device underneath VDO issues an error for a flush, VDO will ignore that error and proceed. This may result in silent data corruption, as those flushes succeeding are necessary for data integrity.

Version-Release number of selected component (if applicable):
6.2.3.107

How reproducible:
Difficult.

Steps to Reproduce:
1. Run VDO on a device which fails and ignores at least some incoming flushes, but no incoming reads/writes.
2. Write some data to VDO.
3. Crash and restart VDO.

Actual results:
VDO will likely go readonly eventually from metadata inconsistency, as well as possible data corruption.


Expected results:
VDO goes read-only immediately upon a failed flush.

Additional info:
Present from 8.0 to the present 6.2.3.107.

Comment 4 Filip Suba 2020-09-09 10:57:00 UTC

Verified SanityOnly. Regression testing passed

Comment 7 errata-xmlrpc 2020-11-04 02:01:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (kmod-kvdo bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4551