Bug 1858603 (rust-simple_asn1)
| Summary: | Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-21 19:05:22 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1269538, 1859151, 1859994 | ||
|
Description
Peter Robinson
2020-07-19 12:49:57 UTC
- You need to add a comment explaining what you modified in the metadata and refer to an upstream PR including that change:
# Initial patched metadata
# - Bump num-bigint to 0.3.0 + link to PR
# - Bump quickcheck to 0.9.2 + link to PR
Patch0: simple_asn1-fix-metadata.diff
- You must include the LICENSE file and should include the README.md:
%files devel
%license LICENSE
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
> - You must include the LICENSE file and should include the README.md:
Why doesn't rust2rpm deal with this?
(In reply to Peter Robinson from comment #3) > > - You must include the LICENSE file and should include the README.md: > > Why doesn't rust2rpm deal with this? rust2rpm depends on the crate metadata provided by the API: https://crates.io/api/v1/crates/num-bigint-dig Some crates link to the README.md in their metadata, others not, and there is no metadata for specifying the license files. So it has to be done manually or detection for license files need to be coded in rust2rpm. > and refer to an upstream PR including that change: I will do upstream PRs when I get time, I have details logged, I don't have the time to do them ATM with other deadlines. > - You must include the LICENSE file and should include the README.md: I've added the README but IMO it doesn't actually provide anything useful to a consumer of the package. SPEC: https://pbrobinson.fedorapeople.org/rust-simple_asn1.spec SRPM: https://pbrobinson.fedorapeople.org/rust-simple_asn1-0.4.1-2.fc32.src.rpm - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-simple_asn1 |