Bug 185930

Summary:	anaconda --rootpath does not restrict itself to rootpath
Product:	[Fedora] Fedora	Reporter:	Jane Dogalt <jdogalt>
Component:	anaconda	Assignee:	Jeremy Katz <katzj>
Status:	CLOSED RAWHIDE	QA Contact:	Mike McLean <mikem>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5
Target Milestone:	---
Target Release:	---
Hardware:	i386
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-04-26 19:18:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	150224

Description Jane Dogalt 2006-03-20 01:23:15 UTC

Description of problem:

Under the assumption that anaconda --rootpath should only be modifying the
contents of rootpath (not other files or state on the host system), there are at
least 3 bugs currently breaking this behavior.

- reconfigures host network
- reconfigures host timezone
- leaves a couple symlinks in /etc.

See kadischi bug 185830 for complete details


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jane Dogalt 2006-04-04 06:27:17 UTC

I'm pretty sure I've at least tracked down the timezone part of this bug-

grepping for localtime in /usr/lib/anaconda/*.py, I see that /etc/localtime gets
written in two places.

in timezone.py, the target installed system's localtime (I.E. instPath +
"/localtime) gets set

iutil.copyFile(fromFile, instPath + "/etc/localtime")

That is as it should be.  The problem however is in packages.py in
setupTimezone, where this happens (note lack of instPath)

            iutil.copyFile(tzfile, "/etc/localtime")

There is already a fallthrough in setupTimezone for testing, i.e.    

# dont do this in test mode!
    if flags.test:
        return

The problem is that this is definately a bad thing to do in --rootpath mode when
rootpath mode is used by kadischi to generate a livecd.  I'm guessing this is a
bad thing to do in rootpath mode in general, but I don't know the anaconda
userbase well enough to say for certain.

I suppose it might be too much to ask for a reference to a design spec which
would define what exactly rootpath should and should not be doing and/or used
for?  I'm just wondering how closely rootpath maps to what kadischi is using it
for, and if another option is necessary.

Comment 2 Jeremy Katz 2006-04-26 19:18:17 UTC

Fixed all of the cases caught here.  If you notice anything else, file them and
I'll take care of them.