Bug 1859387
Summary: | Container Review Request - php-73-fedora - Platform for building and running PHP 7.3 applications | ||
---|---|---|---|
Product: | [Fedora] Fedora Container Images | Reporter: | cragr <craig> |
Component: | Container Review | Assignee: | Athos Ribeiro <athoscribeiro> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 31 | CC: | athoscribeiro, clems.verna, container-review, fedoraproject |
Target Milestone: | --- | Flags: | athoscribeiro:
fedora-review?
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-08-18 17:12:07 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 177841 |
Description
cragr
2020-07-21 21:13:59 UTC
Maybe use a similar image naming scheme as the centos images like php-73-f31 for PHP version 7.3 Fedora version 31? Are you in the packager group already? If not, you may also want to look for a sponsor. See https://fedoraproject.org/wiki/Join_the_package_collection_maintainers Moreover, are you planning on packaging all those files in the directory with the Dockerfile? (In reply to Athos Ribeiro from comment #2) > Are you in the packager group already? > > If not, you may also want to look for a sponsor. > > See https://fedoraproject.org/wiki/Join_the_package_collection_maintainers > > Moreover, are you planning on packaging all those files in the directory with the Dockerfile? > I am not in the packager group and have contacted one person so far for sponsorship, status is pending. I have no plans to package files, the image will be built using that exact Dockerfile.fedora from the sclorg repo. By "packaging files", I mean using the files being copied into the image in the Dockerfile in lines 61 and 64. If so, I believe the files should be linked here for the Review (let me know if you'd like me to go through that repository instead). As for the image name, I believe the $FGC has been dropped from the guidelines, where we should now use just the main component name in the package. Moreover, shouldn't this bug name be the same as the image name and component, i.e., php? Then you could manipulate the image tag depending on the base image used to point to the proper php version you want to ship. Otherwise, we'd have to package/review this image multiple times for different Fedora releases. Thoughts? I am also pinging Clement here to hear his ideas on this one :) I believe the php s2i image is already available https://src.fedoraproject.org/container/php, it has just not been built in a while :( Any objections on closing this as a duplicate of BZ#1445784? (In reply to Clement Verna from comment #6) > I believe the php s2i image is already available > https://src.fedoraproject.org/container/php, it has just not been built in a > while :( Correct. I would like to update these images if possible. The Fedora 31 version would include PHP7.3 an Fedora 32 would include PHP7.4. In this case, you should contact rpitonak ( the owner of https://src.fedoraproject.org/container/php). For the PRs in that repo, he seems to be inactive. If that is the case, you could start a non-responsive packager process. Packaging this under a different name does not seems to be the way forward here though. Closing with recommendation of contacting rpitonak. |