Bug 1859576

Summary: Review Request: perl-XS-Parse-Sublike - XS functions to assist in parsing sub-like syntax
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-XS-Parse-Sublike-0.10-1.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-27 14:28:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1859602    

Description Petr Pisar 2020-07-22 13:36:13 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-XS-Parse-Sublike/perl-XS-Parse-Sublike.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-XS-Parse-Sublike/perl-XS-Parse-Sublike-0.10-1.fc33.src.rpm
Description:
This module provides some XS functions to assist in writing parsers for
sub-like syntax, primarily for authors of keyword plugins using the
PL_keyword_plugin hook mechanism.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2020-07-27 10:14:37 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-XS-Parse-Sublike-0.10-1.fc33.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-XS-Parse-Sublike-0.10-1.fc33.x86_64.rpm | sort | uniq -c
      1 perl(XS::Parse::Sublike) = 0.10
      1 perl-XS-Parse-Sublike = 0.10-1.fc33
      1 perl(XS::Parse::Sublike::Builder) = 0.10
      1 perl-XS-Parse-Sublike(x86-64) = 0.10-1.fc33
Binary provides are Ok.

$ rpmlint ./perl-XS-Parse-Sublike*
perl-XS-Parse-Sublike.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers
perl-XS-Parse-Sublike.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Resolution:
Approved
Comment 2 Petr Pisar 2020-07-27 13:38:17 UTC 
https://pagure.io/releng/fedora-scm-requests/issue/27243
Comment 3 Gwyn Ciesla 2020-07-27 13:45:43 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-XS-Parse-Sublike
Comment 4 Petr Pisar 2020-07-27 14:28:28 UTC 
Thank you for the review and the repository.