Bug 1859602

Summary: Review Request: perl-Object-Pad - Simple syntax for lexical slot-based objects
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Object-Pad-0.31-2.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-28 14:26:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1859576    
Bug Blocks: 1859635    

Description Petr Pisar 2020-07-22 14:55:01 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Object-Pad/perl-Object-Pad.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Object-Pad/perl-Object-Pad-0.31-1.fc33.src.rpm
Description:
This Perl module provides a simple syntax for creating object classes, which
uses private variables that look like lexical variables for object member
fields.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2020-07-27 15:08:54 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Object-Pad-0.31-1.fc33.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(Carp) 
      1 perl(experimental)
      1 perl(feature)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(mro)
      1 perl(Object::Pad)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XSLoader)
      1 perl(XS::Parse::Sublike) >= 0.10
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Object-Pad-0.31-1.fc33.x86_64.rpm | sort | uniq -c
      1 perl(Object::Pad) = 0.31
      1 perl-Object-Pad = 0.31-1.fc33
      1 perl(Object::Pad::MOP::Class) = 0.31
      1 perl(Object::Pad::MOP::Method) = 0.31
      1 perl(Object::Pad::MOP::Slot) = 0.31
      1 perl-Object-Pad(x86-64) = 0.31-1.fc33
Binary provides are Ok.

$ rpmlint ./perl-Object-Pad*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Resolution:
Approved
Comment 2 Petr Pisar 2020-07-27 15:21:29 UTC 
https://pagure.io/releng/fedora-scm-requests/issue/27248
Comment 3 Gwyn Ciesla 2020-07-27 15:58:41 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Object-Pad
Comment 4 Petr Pisar 2020-07-28 07:49:04 UTC 
Thank you for the review and the repository. I will finish bootstrapping this package after packaging all circular dependencies.