Bug 1859814
Summary: | F33FailsToInstall: davix-libs | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Igor Raits <igor.raits> |
Component: | davix | Assignee: | Adrien Devresse <adev88> |
Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | adev88, andrea.manzi, georgios.bitzes, mattias.ellert |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-08-03 19:30:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1803235 |
Description
Igor Raits
2020-07-23 05:38:39 UTC
Davix must be rebuilt for the gsoap soname bump. This would normally have been fixed by the F33 mass rebuild without the maintainer having to do anything. However, the rebuild failed because the davix package was not adapted to the new definition of the %cmake macro. https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds Suggested fix in PR: https://src.fedoraproject.org/rpms/davix/pull-request/1 Someone just fixed this and did a rebuild for rawhide. So no more urgent actions are needed. The fix in master works for Fedora 31 and later. To work for EPEL 8 the "%cmake_build --target doc" must be changed to "%cmake_build -- doc" due to the older cmake version in RHEL 8 (that would work for Fedora too). It will not work for EPEL 6 and 7, without adding the tweaks I proposed in my PR. Depends on whether you want the same spec everywhere or not. Alternatively, if you switch to cmake3 in EPEL 7 you can use the new macros with other names: %cmake → %cmake3 %cmake_build → %cmake3_build %cmake_install → &cmake3_install if you add "%undefine __cmake3_in_source_build" to the specfile. The %cmake3* macros are defined as aliases for the %cmake* ones in EPEL 8 and Fedora. This would just leave EPEL 6 as the odd one out (which is EOL before the end of the year), and there would be no tweaks for EPEL 7-8 and Fedora 31+. Thanks Mattias for the pull request, and useful advice. As a first step, I'll change the specfile in davix CI based on your suggestions to ensure compatibility with EPEL and older fedora versions. Having the same specfile everywhere would be nice. Afterwards I'll change the Fedora specfile, too. I'm not sure it's possible to merge your PR as-is anymore due to the fixes from Igor, should I close it? Cheers, Georgios Hello, Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (ignatenkobrain). All subpackages of a package against which this bug was filled are now installable or removed from Fedora 33. Thanks for taking care of it! (In reply to Georgios Bitzes from comment #4) > I'm not sure it's possible to merge your PR as-is anymore due to the fixes > from Igor, should I close it? I have rebased the PR onto current master. |