Bug 1860594

Summary: Toolbox pod should have toleration for OCS tainted nodes
Product: [Red Hat Storage] Red Hat OpenShift Container Storage Reporter: Neha Berry <nberry>
Component: ocs-operatorAssignee: N Balachandran <nibalach>
Status: CLOSED ERRATA QA Contact: Shrivaibavi Raghaventhiran <sraghave>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.5CC: ebenahar, jarrpa, madam, muagarwa, nibalach, ocs-bugs, shan, sostapov, tdesala
Target Milestone: ---   
Target Release: OCS 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-19 09:14:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 2 Sébastien Han 2020-07-27 13:08:41 UTC
AFAIK ocs-op deploys the toolbox so change component.

Comment 3 Jose A. Rivera 2020-08-03 16:59:44 UTC
This is valid, but since there will likely be worker nodes without the OCS taint on them in the cluster, this is not a blocker. Moving to OCS 4.6

Comment 4 Jose A. Rivera 2020-10-05 14:22:29 UTC
Still not a blocker, and we're right up against devel freeze. Moving again to OCS 4.7.

Comment 5 N Balachandran 2020-10-09 07:21:28 UTC
PR created : https://github.com/openshift/ocs-operator/pull/815

ocs-metrics-exporter pod will also not run if there are no untainted nodes. Should I go ahead and add a toleration for that as well?

Comment 6 N Balachandran 2020-10-23 04:15:30 UTC
Moving this to MODIFIED as the upstream PR has been merged into the master branch.

Comment 7 Mudit Agarwal 2020-10-23 06:49:43 UTC
Do we need this in 4.6?

Comment 8 N Balachandran 2020-10-23 07:54:39 UTC
(In reply to Mudit Agarwal from comment #7)
> Do we need this in 4.6?

I don't think so - IMO it is not really critical.

Comment 10 Shrivaibavi Raghaventhiran 2021-02-02 11:15:25 UTC
Versions Tested:
-----------------
OCP : 4.7.0-0.nightly-2021-02-02-033055
OCS : ocs-operator.v4.7.0-241.ci

Steps to verify:
-----------------

1. Toolbox yaml has the toleration added
  tolerations:
  - effect: NoSchedule
    key: node.ocs.openshift.io/storage
    operator: Equal
    value: "true"

2. Respin toolbox pod and see if it comes up on tainted node


The tests passed, Moving the BZ to verified state.

Comment 13 errata-xmlrpc 2021-05-19 09:14:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenShift Container Storage 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2041

Comment 14 Red Hat Bugzilla 2023-09-15 00:34:40 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days