Bug 1860977

Summary: OCS 4.5 StorageCluster Creation Page: Make the Node Labelling Note more generic to accomodate LSO and dynamic prov. cluster
Product: OpenShift Container Platform Reporter: Neha Berry <nberry>
Component: Console Storage PluginAssignee: Ankush Behl <anbehl>
Status: CLOSED ERRATA QA Contact: Neha Berry <nberry>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.5CC: anbehl, aos-bugs, edonnell, jefbrown, madam, nthomas, ocs-bugs, sdodson
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1866330 (view as bug list) Environment:
Last Closed: 2020-10-27 16:17:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1866330    
Attachments:
Description Flags
UI-StorageCluster-Creation none

Description Neha Berry 2020-07-27 15:21:50 UTC 
Created attachment 1702550 [details]
UI-StorageCluster-Creation

Description of problem:
----------------------------
With OCS 4.5 + OCP 4.5, the Storage Cluster creation is supported from UI for LSO(BM/Vsphere) as well. 

But the Nodes are recommended to be labelled as a pre-requisite for LocalVolumeCR as well.

Then when one navigates to Create OCS Storage CLuster Service Page, a user sees following Note(attached screenshot). This can confuse users as they have already labelled the nodes for OCS

Current Note:

Nodes
Selected nodes will be labeled with cluster.ocs.openshift.io/openshift-storage="" to create the OCS Service.

Recommended Note:

Nodes
>> Selected nodes will be labeled with cluster.ocs.openshift.io/openshift-storage="" to create the OCS service unless they are already labeled"

More discussions here - https://chat.google.com/room/AAAA76Pbvwc/-TGGnRpE5Uo
Version-Release number of selected component (if applicable):


How reproducible:
--------------------

Always


Versions
----------
OCP  = 4.5.0-0.nightly-2020-07-25-031342
OCS = 4.5


Steps to Reproduce:
------------------------
1. Follow deployment Guide [1] to install OCS via UI on BM
2. Check the Note for Node label in the Create Storage CLuster Service Page. It 
3.

[1] - https://access.redhat.com/documentation/en-us/red_hat_openshift_container_storage/4.5/html-single/deploying_openshift_container_storage/index?lb_target=preview#creating-openshift-container-storage-cluster-on-bare-metal_aws-vmware


Actual results:
-----------------------
In case Nodes are already labelled, the current Note may confuse users.

Expected results:
---------------------
The Note for Node label can be made generic to be applicable for both LSO(nodes are already labelled beforehand) and dynamic provisioned clusters(nodes are not labelled beforehand)


Additional info:
Comment 3 Neha Berry 2020-07-27 15:39:42 UTC 
One more bug for requested changes in the Create Storage CLuster Page - https://bugzilla.redhat.com/show_bug.cgi?id=1860985
Comment 7 Nishanth Thomas 2020-07-30 12:41:30 UTC 
Moving this to 4.6.0. Once the PR is merged, need to backport to 4.5.z
Comment 13 Neha Berry 2020-08-07 06:54:57 UTC 
Moved to verified based on Comment#12
Comment 16 errata-xmlrpc 2020-10-27 16:17:21 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196
Comment 17 errata-xmlrpc 2020-10-27 16:20:27 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196