Bug 1861397

Summary:	UI dialog for Capsule Upgrade Playbook job doesn't state whitelist_options is required
Product:	Red Hat Satellite	Reporter:	Peter Ondrejka <pondrejk>
Component:	Ansible - Configuration Management	Assignee:	Adam Ruzicka <aruzicka>
Status:	CLOSED ERRATA	QA Contact:	Vladimír Sedmík <vsedmik>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.8.0	CC:	ahumbe, aruzicka, inecas, mawerner, pcreech, vsedmik
Target Milestone:	6.8.0	Keywords:	PrioBumpGSS, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	tfm-rubygem-foreman_ansible-5.1.2	Doc Type:	Known Issue
Doc Text:	UI dialog for Capsule Upgrade Playbook job doesn't state whitelist_options is required	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 13:04:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Peter Ondrejka 2020-07-28 14:06:03 UTC

Description of problem:
Running Capsule Upgrade Playbook job without specifying whitelist_options fails with: 
ERROR: option '--whitelist': value not specified"

UI does not mark whitelist_options as required

Version-Release number of selected component (if applicable):
Satellite 6.8 snap 10

How reproducible:
always

Steps to Reproduce:
1. Have a Satellite and a Capsule registered to it
2. Monitor > Jobs > Run Job > 
3. Fill the fileds
   Job category : Ansible Playbook
   Job template : Capsule Upgrade Playbook
   Search Query : name ~ <caps-fqdn>
   target_version : 6.8
leave whitelist_options blank

Actual results:
ERROR: option '--whitelist': value not specified"

Expected results:
Either the playbook should succeed without whitelist_options specified, or job invocation dialog should mark the option as required. Also some explanation of the parameter would be nice

Additional info:

Comment 1 Adam Ruzicka 2020-08-03 09:53:18 UTC

The template lives in foreman_ansible, changing component to ansible

Comment 2 Adam Ruzicka 2020-08-03 10:54:29 UTC

Created redmine issue http://projects.theforeman.org/issues/30545 from this bug

Comment 3 Bryan Kearney 2020-08-10 00:03:52 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/30545 has been resolved.

Comment 4 Tomer Brisker 2020-08-24 11:05:22 UTC

*** Bug 1867153 has been marked as a duplicate of this bug. ***

Comment 5 Patrick Creech 2020-08-26 16:40:58 UTC

Adam,

Is there a way we can get a 5.1.z release upstream with this fix in it?

Comment 6 Adam Ruzicka 2020-08-27 12:46:09 UTC

I was planning on releasing it tomorrow or on Monday in the worst case scenario

Comment 7 Vladimír Sedmík 2020-09-14 14:33:57 UTC

Verified on Sat 6.8.0 snap 15, tfm-rubygem-foreman_ansible-5.1.3-1.el7sat.noarch - whitelist_options are now optional (can be omitted).

Comment 10 errata-xmlrpc 2020-10-27 13:04:48 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.8 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4366