Bug 1861518

Summary: VDO Monitoring scripts have mixed-up arguments in the comments
Product: Red Hat Enterprise Linux 8 Reporter: Andy Walsh <awalsh>
Component: vdoAssignee: Matthew Sakai <msakai>
Status: CLOSED ERRATA QA Contact: Filip Suba <fsuba>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: awalsh, fsuba
Target Milestone: rc   
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 6.2.3.114 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 02:01:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Andy Walsh 2020-07-28 20:05:53 UTC 
Description of problem:
Per a github pull request [0], the arguments for critical and warn values are all mixed up in the monitor_check_vdostats_logicalSpace.pl, monitor_check_vdostats_physicalSpace.pl, and monitor_check_vdostats_savingPercent.pl scripts.


[0] https://github.com/dm-vdo/vdo/pull/32

Version-Release number of selected component (if applicable):
6.2.3.107

How reproducible:
100%

Steps to Reproduce:
1. Install vdo package
2. Look at the comments for Options in these files:
/usr/share/doc/vdo/examples/monitor/monitor_check_vdostats_logicalSpace.pl
/usr/share/doc/vdo/examples/monitor/monitor_check_vdostats_physicalSpace.pl
/usr/share/doc/vdo/examples/monitor/monitor_check_vdostats_savingPercent.pl

Actual results:
# Options:
#
# -c <warn_pct>: critical threshold equal to or greater than
#                <warn_pct> percent.
#
# -w <crit_pct>: warning threshold equal to or greater than
#                <crit_pct> percent.


Expected results:
# Options:
#
# -c <crit_pct>: critical threshold equal to or greater than
#                <warn_pct> percent.
#
# -w <warn_pct>: warning threshold equal to or less than
#                <crit_pct> percent.
Comment 4 Filip Suba 2020-08-21 08:31:50 UTC 
Verified with vdo-6.2.3.114-14.el8. 

# Options:
#
# -c <crit_pct>: critical threshold equal to or greater than
#                <warn_pct> percent.
#
# -w <warn_pct>: warning threshold equal to or less than
#                <crit_pct> percent.
Comment 7 errata-xmlrpc 2020-11-04 02:01:49 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (kmod-kvdo bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4551