Bug 1861839

> # The library has a "constants.php" file and relies on autoloading it,

Indeed, in composer.json

    "autoload": {
        "classmap": ["lib"],
        "files": ["lib/constants.php"]
    },

Simpler way is to include this file from the generated autoloader, Ex:

cat << 'EOF' >>autoload.php
require_once "lib/constants.php";
EOF


IMHO, the "lib" directory is not needed in the package tree


From phpcompatinfo analysis, and per PHP Guidelines, you need to require:

php-simplexml
php-date
php-pcre

Created attachment 1712177 [details]
phpci.log

> Simpler way is to include this file from the generated autoloader
I guess that works, too.

> From phpcompatinfo analysis, and per PHP Guidelines, you need to require:
> php-simplexml
> php-date
> php-pcre
Thanks. Added.

spec: https://svgames.pl/fedora/php-openpsa-universalfeedcreator-1.8.3.2-2/php-openpsa-universalfeedcreator.spec
srpm: https://svgames.pl/fedora/php-openpsa-universalfeedcreator-1.8.3.2-2/php-openpsa-universalfeedcreator-1.8.3.2-2.fc32.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=49808924

> sed -e 's|/lib/|/|g' -i autoload.php

TIPS: generate the autoolader directly in lib (--output=lib/autoload.php) or use --basedir option to avoid having this sed

> # Upstream repo does not contain a LICENSE file

It have been recently added
https://github.com/flack/UniversalFeedCreator/blob/master/LICENSE

Find to add it later, on next version upgrade, ad LGPL doesn't require it to be present.

Created attachment 1712302 [details]
review.txt

[x]: Package complies to the Packaging Guidelines


See minor TIPS above, but no blocker


** APPROVED **

Thanks for the review. Please assign the ticket to yourself (required per "fedpkg request-repo" procedures).

(In reply to Artur Iwicki from comment #8)
> Thanks for the review. Please assign the ticket to yourself (required per
> "fedpkg request-repo" procedures).

Sorry about this, done.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-openpsa-universalfeedcreator

FEDORA-2020-2fedbc41d5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2fedbc41d5

FEDORA-2020-12738c06ed has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-12738c06ed

FEDORA-2020-12738c06ed has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-12738c06ed`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-12738c06ed

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-2fedbc41d5 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-2fedbc41d5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-2fedbc41d5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-12738c06ed has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2020-2fedbc41d5 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.