Bug 1861908

Summary:	Plan validation GVK warnings should not show kinds that are ignored via exclude_resources
Product:	OpenShift Container Platform	Reporter:	John Matthews <jmatthew>
Component:	Migration Tooling	Assignee:	John Matthews <jmatthew>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Xin jiang <xjiang>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	4.4	CC:	mberube, rjohnson, sregidor, vlaad, xjiang
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1861904	Environment:
Last Closed:	2022-08-26 13:53:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1861904

Description John Matthews 2020-07-29 21:10:17 UTC

+++ This bug was initially created as a clone of Bug #1861904 +++

Description of problem:
The GVK warnings should not include warnings that the controller has been configured to ignore via exclude_resources, which is set on the controller by the operator as an environment variable. This could potentially lead to user confusion.

For example, by default, the CAM 1.2.4 operator excludes all kinds that are part of the service catalog's group. Often the GVK warning will trigger for service catalog objects, but as of 1.2.4, they're being ignored anyway, so we shouldn't warn.

Version-Release number of selected component (if applicable):
CAM 1.2.4

How reproducible:
Every time

Steps to Reproduce:
1. Use a source cluster that would trigger a GVK warning due to service catalog resources
2. Deploy CAM with 1.2.4 operator, this will have the service catalog resources as part of exclude_resources

Actual results:
catalog GVK warning will be written to the CR

Expected results:
catalog GVK warning should not be present, because the controller is configured to ignore them.

Comment 2 John Matthews 2020-09-16 15:29:53 UTC

The work for this was address in a prior z-stream tracked in:
https://bugzilla.redhat.com/show_bug.cgi?id=1861904

Comment 3 Sergio 2020-09-18 12:29:41 UTC

Verified using MTC 1.3

openshift-migration-rhel7-operator@sha256:233af9517407e792bbb34c58558346f2424b8b0ab54be6f12f9f97513e391a6a

We deployed an application in 3.11 using the service catalog. Then we created a migration plan in order to migrate to 4.5. No warning was displayed.

Moved to VERIFIED status.