Bug 1862101

Summary: rhv-image-discrepancies does show size of the images on the storage as size of the image in db and vice versa
Product: Red Hat Enterprise Virtualization Manager Reporter: Marian Jankular <mjankula>
Component: rhv-log-collector-analyzerAssignee: Germano Veit Michel <gveitmic>
Status: CLOSED ERRATA QA Contact: Guilherme Santos <gdeolive>
Severity: low Docs Contact:
Priority: medium    
Version: 4.3.8CC: dougsland, germano, gveitmic, mavital
Target Milestone: ovirt-4.4.3Keywords: FieldEngineering
Target Release: 4.4.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rhv-log-collector-analyzer-1.0.3-1.el8ev Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-24 13:09:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marian Jankular 2020-07-30 13:03:43 UTC
Description of problem:


Version-Release number of selected component (if applicable):
rhv-log-collector-analyzer-0.2.16-0.el7ev.noarch

How reproducible:
everytime

Steps to Reproduce:
1. set size of the image to wrong value
2. run rhv-image-discrepancies

Actual results:
        image 403d7f53-3f04-4cbd-aafb-93f32151aa54 has a different attribute capacity on storage(962592768) and on DB(1073741824)

engine=# select storage_id,image_group_id, image_guid,size from all_disks_including_snapshots where disk_alias='CentOS-7-x86_64-Minimal-1810.iso';
              storage_id              |            image_group_id            |              image_guid              |   size    
--------------------------------------+--------------------------------------+--------------------------------------+-----------
 6814fac1-2e9a-4ab3-bbfe-02a14c2049fe | 700ba928-dfba-4242-866e-1c0b7a205e3b | 403d7f53-3f04-4cbd-aafb-93f32151aa54 | 962592768

# su vdsm -s /bin/sh -c 'qemu-img info  /dev/6814fac1-2e9a-4ab3-bbfe-02a14c2049fe/403d7f53-3f04-4cbd-aafb-93f32151aa54'
image: /dev/6814fac1-2e9a-4ab3-bbfe-02a14c2049fe/403d7f53-3f04-4cbd-aafb-93f32151aa54
file format: raw
virtual size: 1.0G (1073741824 bytes)
disk size: 0



Expected results:
the values will be displayed correctly as below:

image 403d7f53-3f04-4cbd-aafb-93f32151aa54 has a different attribute capacity on storage(1073741824) and on DB(962592768)
Additional info:

Comment 1 Douglas Schilling Landgraf 2020-07-30 23:50:14 UTC
Hi Germano,

Could you please review this report?

Comment 2 Germano Veit Michel 2020-07-30 23:58:00 UTC
Humpf, they are all inverted, not just size:

print("\timage {} has a different attribute {} on storage({}) and on DB({})".format(
     image, key, db_value, sd_value)
)

I'll send a fix along with some other improvements I'm planning after switching to the new
sd dump api.

Comment 4 Germano Veit Michel 2020-08-05 04:23:22 UTC
Douglas, is the 4.4.z analyser based on the master branch?

Shall we raise 4.4.z flag?

Comment 5 Douglas Schilling Landgraf 2020-08-05 14:09:24 UTC
(In reply to Germano Veit Michel from comment #4)
> Douglas, is the 4.4.z analyser based on the master branch?
> 
> Shall we raise 4.4.z flag?

Sure, let's get all acks. (devel, qe, pm)

Comment 9 Guilherme Santos 2020-10-29 22:09:57 UTC
Verified on:
ovirt-engine-4.4.3.8-0.1.el8ev.noarch
rhv-log-collector-analyzer-1.0.5-1.el8ev.noarch

Steps:
1. set a wrong size value for a random img on db
engine=# update images set size = 10000000000 where image_guid='ad116098-16a1-40f5-999e-0a1997ef93f0';
engine=# select storage_id,image_group_id, image_guid,size from all_disks_including_snapshots where image_guid='ad116098-16a1-40f5-999e-0a1997ef93f0';
                                                   storage_id                                                   |            image_group_id            |              image_guid              |    size     
----------------------------------------------------------------------------------------------------------------+--------------------------------------+--------------------------------------+-------------
 c9b18e61-7a79-4f36-9348-686cae48a946,aaa103b6-a9f3-4957-89e4-1951daf8d7f7,bccc676d-0602-44b6-927e-42c9c91d132f | f0f4aa50-ac3e-4fac-8cba-31a88a8d8ee4 | ad116098-16a1-40f5-999e-0a1997ef93f0 | 10000000000
(1 row)

2. checked real img size
sh-4.4$ qemu-img info /rhev/data-center/mnt/<nfs_export>/aaa103b6-a9f3-4957-89e4-1951daf8d7f7/images/f0f4aa50-ac3e-4fac-8cba-31a88a8d8ee4/ad116098-16a1-40f5-999e-0a1997ef93f0
image: /rhev/data-center/mnt/<nfs_export>/aaa103b6-a9f3-4957-89e4-1951daf8d7f7/images/f0f4aa50-ac3e-4fac-8cba-31a88a8d8ee4/ad116098-16a1-40f5-999e-0a1997ef93f0
file format: qcow2
virtual size: 10 GiB (10737418240 bytes)
disk size: 1.93 GiB
cluster_size: 65536
Format specific information:
    compat: 1.1
    compression type: zlib
    lazy refcounts: false
    refcount bits: 16
    corrupt: false

3. # rhv-image-discrepancies
...
	 Image ad116098-16a1-40f5-999e-0a1997ef93f0 has a different attribute capacity on storage(10737418240) and on DB(10000000000)
...

Results:
size values displayed by rhv-image-discrepancies correctly matching their sources

Comment 13 errata-xmlrpc 2020-11-24 13:09:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: Red Hat Virtualization security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5179

Comment 14 meital avital 2022-05-19 15:30:28 UTC
Due to QE capacity we are not going to cover this issue in our automation