Bug 1862149

Summary: Missing quotes in tripleo_common/inventories.py prevent host vars to be populated properly
Product: Red Hat OpenStack Reporter: Cédric Jeanneret <cjeanner>
Component: openstack-tripleo-commonAssignee: Cédric Jeanneret <cjeanner>
Status: CLOSED ERRATA QA Contact: David Rosenfeld <drosenfe>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 16.1 (Train)CC: aschultz, gchamoul, jhajyahy, mburns, mgarciac, slinaber
Target Milestone: z3Keywords: Triaged
Target Release: 16.1 (Train on RHEL 8.2)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-common-11.4.1-1.20200917023445.el8ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-12-15 18:36:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Cédric Jeanneret 2020-07-30 14:45:17 UTC
A term isn't quoted in the code, preventing the additional host vars to be present in the inventory:
https://opendev.org/openstack/tripleo-common/src/branch/stable/train/tripleo_common/inventories.py#L89

Comment 2 Cédric Jeanneret 2020-11-24 09:12:00 UTC
To Verify it:
- deploy undercloud + small overcloud (just one node is enough)
- generate the inventory using the standard tripleo-ansible-inventory --os-cloud undercloud --static-yaml-inventory foo.yaml
- ensure you get "container_cli" in the generated file

Comment 3 Jad Haj Yahya 2020-11-24 10:15:51 UTC
 tripleo-ansible-inventory --os-cloud undercloud --static-yaml-inventory foo.yaml
- ensure you get "container_cli" in the generated file

Comment 12 errata-xmlrpc 2020-12-15 18:36:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1.3 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:5413