Bug 1862278

Document URL: 
https://docs.openshift.com/container-platform/4.5/installing/installing_gcp/installing-gcp-user-infra-vpc.html#installation-creating-gcp-lb_installing-gcp-user-infra-vpc


Suggestions for improvement: 
#1 Sample customized install-config.yaml file for GCP
https://docs.openshift.com/container-platform/4.5/installing/installing_gcp/installing-gcp-user-infra-vpc.html#installation-gcp-user-infra-shared-vpc-config-yaml_installing-gcp-user-infra-vpc

In the sample, <ADD a note to>
ProjectID: openshift-production 5

5 Specify your main project where the VM instances will reside (not the host project)
 
(change the numbers of notes after this as well)

#2 Deployment Manager template for the internal load balancer

After the 02_lb_int.py template
<ADD>
You will need this in addition to the 02_lb_ext.py when you create external cluster.

#3
https://docs.openshift.com/container-platform/4.5/installing/installing_gcp/installing-gcp-user-infra-vpc.html#installation-creating-gcp-worker_installing-gcp-user-infra-vpc

Creating Additional worker machine, step 2a, this line doesn't seem to be right:
export COMPUTE_SUBNET=$(gcloud compute networks subnets describe ${HOST_PROJECT_COMPUTE_SUBNET} --region=${REGION} --project ${HOST_PROJECT} --account ${HOST_PROJECT_ACCOUNT} --format json | jq -r .selfLink)`

Should be:
export COMPUTE_SUBNET=`gcloud compute networks subnets describe ${HOST_PROJECT_COMPUTE_SUBNET} --region=${REGION} --project ${HOST_PROJECT} --account ${HOST_PROJECT_ACCOUNT} --format json | jq -r .selfLink`

#4 
https://docs.openshift.com/container-platform/4.5/installing/installing_gcp/installing-gcp-user-infra-vpc.html#installation-gcp-user-infra-adding-ingress_installing-gcp-user-infra-vpc
Adding the ingress DNS records

First paragrapg:
If you removed the DNS Zone configuration when creating Kubernetes manifests and generating Ignition configs, you must manually create DNS records that point at the ingress load balancer. 

<Change to>:
DNS Zone configuration has been removed when creating Kubernetes manifests and generating Ignition configs, you must manually create DNS records that point at the ingress load balancer. 

Note: This sections covers an optional step in other types of installation but it is mandatory for shared vpc install. Hence the change and this change should NOT be propagated to other installation types.
(

#5
https://docs.openshift.com/container-platform/4.5/installing/installing_gcp/installing-gcp-user-infra-vpc.html#installation-gcp-user-infra-vpc-adding-firewall-rules

<ADD to the 'code block' starting with 'Firewall change required by security admin:....' (before the existing text in the box)>
./oc get events -n openshift-ingress --field-selector="reason=LoadBalancerManualChange"