Bug 1862371

Summary:	CVE-2020-15945 compat-lua: lua: segmentation fault in changedline in ldebug.c [fedora-all]
Product:	[Fedora] Fedora	Reporter:	Riccardo Schirone <rschiron>
Component:	compat-lua	Assignee:	Hans de Goede <hdegoede>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	32	CC:	fedora, hdegoede, moceap
Target Milestone:	---	Keywords:	Security, SecurityTracking
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-25 08:00:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1861999

Description Riccardo Schirone 2020-07-31 09:17:12 UTC

This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of fedora-all.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

Comment 1 Riccardo Schirone 2020-07-31 09:17:15 UTC

Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# low, medium, high, urgent (required)
severity=medium

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1861999,1862371

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Hans de Goede 2020-08-10 10:14:49 UTC

According to:
https://github.com/lua/lua/commit/a2195644d89812e5b157ce7bac35543e06db05e3.patch

The problem is "The field 'L->oldpc' is not always updated when control returns to a function;"

compat-lua / lua 5.1 does not have an oldpc variable in its state-struct, so it cannot go stale / end up pointing to no longer valid memory since it does not exist.

As such I believe that this CVE does not apply to compat-lua.

How should we move forward with this bug?

Comment 3 Riccardo Schirone 2020-08-25 07:03:42 UTC

(In reply to Hans de Goede from comment #2)
> According to:
> https://github.com/lua/lua/commit/a2195644d89812e5b157ce7bac35543e06db05e3.
> patch
> 
> The problem is "The field 'L->oldpc' is not always updated when control
> returns to a function;"
> 
> compat-lua / lua 5.1 does not have an oldpc variable in its state-struct, so
> it cannot go stale / end up pointing to no longer valid memory since it does
> not exist.
> 
> As such I believe that this CVE does not apply to compat-lua.
> 
> How should we move forward with this bug?

Sorry for the late reply, I was on vacation.
Just close this bug as NOTABUG and that's it.

Thanks for looking at it.