Bug 1862430

Summary: LSO: PV creation lock should not be acquired in a loop
Product: OpenShift Container Platform Reporter: Rohan CJ <rojoseph>
Component: StorageAssignee: Rohan CJ <rojoseph>
Storage sub component: Local Storage Operator QA Contact: Chao Yang <chaoyang>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: unspecified CC: aos-bugs, hekumar, jsafrane
Version: 4.6   
Target Milestone: ---   
Target Release: 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-24 15:13:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Rohan CJ 2020-07-31 12:29:51 UTC 
Description of problem:

The PV lock acquisition and symlinking should be contained in one function so that lock release is guaranteed.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 Rohan CJ 2020-09-08 07:38:15 UTC 
Moving out, as this is a maintainability issue and this does not impact functionality or reliability.
Comment 5 Chao Yang 2020-12-02 12:42:11 UTC 
oc get pv
NAME                CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS     CLAIM       STORAGECLASS   REASON   AGE
local-pv-296e1b66   10Gi       RWO            Delete           Released   test/pvc1   lvs                     12m
[chaoyang@dhcp-141-216 localvolume]$ oc get pv
NAME                CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS      CLAIM   STORAGECLASS   REASON   AGE
local-pv-296e1b66   10Gi       RWO            Delete           Available           lvs                     5s

local-storage-operator.4.7.0-202011261728.p0   Local Storage   4.7.0-202011261728.p0              Succeeded
Comment 8 errata-xmlrpc 2021-02-24 15:13:58 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633