Bug 1862432

Summary:	prometheus-adapter is missing a service monitor
Product:	OpenShift Container Platform	Reporter:	Sergiusz Urbaniak <surbania>
Component:	Monitoring	Assignee:	Sergiusz Urbaniak <surbania>
Status:	CLOSED ERRATA	QA Contact:	Junqi Zhao <juzhao>
Severity:	low	Docs Contact:
Priority:	high
Version:	4.6	CC:	alegrand, anpicker, erooth, kakkoyun, lcosic, mloibl, pkrupa, surbania
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:21:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sergiusz Urbaniak 2020-07-31 12:33:34 UTC

prometheus-adapter is currently only being monitored via means of availability in the api service Kubernetes registry.

We miss a proper service monitor. Additionally we could gain insights in the future.

It was contributed upstream https://github.com/coreos/kube-prometheus/pull/622 and we should enable it downstream too.

Comment 1 Sergiusz Urbaniak 2020-07-31 13:30:21 UTC

This was just posted, there was no time to add support this sprint.

Comment 2 Sergiusz Urbaniak 2020-08-12 07:19:11 UTC

setting priority to high but severity to low. reasoning: we really want this in, preferably in 4.6. But if 4.6 ships without it nothing breaks.

Comment 3 Sergiusz Urbaniak 2020-08-21 13:46:06 UTC

UpcomingSprint: not enough time/capacity to tackle the issue this sprint.

Comment 6 Junqi Zhao 2020-09-14 03:44:49 UTC

tested with 4.6.0-0.nightly-2020-09-12-230035, prometheus-adapter servicemonitor is added, and the targets are monitored
# oc -n openshift-monitoring get servicemonitor prometheus-adapter
NAME                 AGE
prometheus-adapter   4h12m

# oc -n openshift-monitoring get ep prometheus-adapter
NAME                 ENDPOINTS                         AGE
prometheus-adapter   10.128.2.6:6443,10.131.0.5:6443   4h19m

# token=`oc sa get-token prometheus-k8s -n openshift-monitoring`
# oc -n openshift-monitoring exec -c prometheus prometheus-k8s-0 -- curl -k -H "Authorization: Bearer $token" 'https://prometheus-k8s.openshift-monitoring.svc:9091/api/v1/targets' | jq | grep -E "\"scrapePool\"|\"scrapeUrl\"|\"health\"" | grep "prometheus-adapter" -A3
        "scrapePool": "openshift-monitoring/prometheus-adapter/0",
        "scrapeUrl": "https://10.128.2.6:6443/metrics",
        "health": "up"
        "scrapePool": "openshift-monitoring/prometheus-adapter/0",
        "scrapeUrl": "https://10.131.0.5:6443/metrics",
        "health": "up"

Comment 8 errata-xmlrpc 2020-10-27 16:21:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196