Bug 1862554 (rust-biscuit)
| Summary: | Review Request: rust-biscuit - Library to work with Javascript Object Signing and Encryption(JOSE) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-08-20 15:01:26 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1862548 | ||
| Bug Blocks: | 1859994, 1868602 | ||
|
Description
Peter Robinson
2020-07-31 17:14:32 UTC
+ package name is OK + latest version + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + rust2rpm was used, so the packaging is standard Issues: Summary is longer than ~70 characters. Something like "Library for Javascript Object Signing and Encryption, JSON Web Tokens, JSON Web Signature and Encryption" would be better. rpmlint: rust-biscuit-devel.noarch: E: summary-too-long C Library to work with Javascript Object Signing and Encryption(JOSE), including JSON Web Tokens (JWT), JSON Web Signature (JWS) and JSON Web Encryption (JWE) See above. rust-biscuit-devel.noarch: W: invalid-url URL: https://crates.io/crates/biscuit HTTP Error 404: Not Found Bogus. rust-biscuit-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/biscuit-0.5.0-beta2/.cargo-checksum.json OK. rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/CHANGELOG.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/LICENSE rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/README.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/doc/README.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/doc/supported.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/digest.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/errors.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/helpers/mod.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/helpers/presence.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/helpers/temporal_options.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/helpers/validation.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/jwa.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/jwe.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/jwk.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/jws.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/lib.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/macros.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/base64_url_uint.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/byte_sequence.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/mod.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/option_base64_url_uint.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/option_byte_sequence.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/test.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/test/fixtures/jwk_private_key.json rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/test/fixtures/jwk_public_key.json rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/test/fixtures/rsa_private_key.pem rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/test/fixtures/rsa_public_key.pem rust-biscuit-devel.noarch: W: spurious-executable-perm /usr/share/doc/rust-biscuit-devel/README.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/licenses/rust-biscuit-devel/LICENSE It seems that the executable bit is set on those files. This should be fixed upstream. Package is APPROVED. > Issues: > Summary is longer than ~70 characters. Something like > "Library for Javascript Object Signing and Encryption, JSON Web Tokens, JSON > Web Signature and Encryption" > would be better. I'd already fixed that locally. > rust-biscuit-devel.noarch: W: invalid-url URL: > https://crates.io/crates/biscuit HTTP Error 404: Not Found > Bogus. That works for me. >> Bogus.
> That works for me.
"Bogus" in this case refers to the rpmlint message: it's a well-known false positive.
(404 is returned because the server doesn't like rpmlint's agent string or something like
that.)
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-biscuit |