Bug 1862725

Fixes for kwallet and updates of translations. Besides commits primarily dedicated to wind*.

Latest upstream release: 3.2.1
Current version/release in rawhide: 3.1.0-8.fc32
URL: https://github.com/mhogomchungu/lxqt_wallet

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/11193/

3.2.1 is fine for sirikali but zulucrypt fails to build:

/home/gwyn/fedora/git/zulucrypt/zuluCrypt-5.7.1/zuluCrypt-gui/secrets.cpp: In member function 'LXQt::Wallet::Wallet** secrets::internalWallet()':
/home/gwyn/fedora/git/zulucrypt/zuluCrypt-5.7.1/zuluCrypt-gui/secrets.cpp:53:41: error: cannot convert 'std::unique_ptr<LXQt::Wallet::Wallet>' to 'LXQt::Wallet::Wallet*' in assignment
   53 |   m_internalWallet = w::getWalletBackend( w::BackEnd::internal ) ;
      |                      ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
      |                                         |
      |                                         std::unique_ptr<LXQt::Wallet::Wallet>
/home/gwyn/fedora/git/zulucrypt/zuluCrypt-5.7.1/zuluCrypt-gui/secrets.cpp: In member function 'secrets::wallet secrets::walletBk(LXQt::Wallet::BackEnd)':
/home/gwyn/fedora/git/zulucrypt/zuluCrypt-5.7.1/zuluCrypt-gui/secrets.cpp:67:40: error: could not convert 'LXQt::Wallet::getWalletBackend(LXQt::Wallet::BackEnd)()' from 'std::unique_ptr<LXQt::Wallet::Wallet>' to 'secrets::wallet'
   67 |   return LXQt::Wallet::getWalletBackend( e ) ;
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
      |                                        |
      |                                        std::unique_ptr<LXQt::Wallet::Wallet>

Thanks for debugging. zulucrypt ships alternatively an embedded version of lxqt-wallet. Will take a closer look into.

Propably we'd need a new release of zulucrypt as well to continue with unbundling of lxqt-wallet. 
Taking maintainer of zulucrypt in the boat, please can you request upstream to keep compatibility with API as unbundling is explicitly featured (-DINTERNAL_LXQT_WALLET=false).

Any ETA on upgrading lxqt-wallet?

(In reply to Gwyn Ciesla from comment #6)
> Any ETA on upgrading lxqt-wallet?

Waiting for clarification about dependencies as a response to my comment #5:
> Propably we'd need a new release of zulucrypt as well to continue with unbundling of lxqt-wallet.

If they don't provide said feedback and you'd like a hand, let me know.

As mentioned in comment #3, there seems to be an issue with API of (dropped?) method getWalletBackend but needed for zulucrypt to be able to unbundle. Maybe we can use a downstream patch.

I'm all for unbundling but it would require that somebody is providing a patch. At the moment I'm simply trying to keep zulucrypt in Fedora.

(In reply to Fabian Affolter from comment #10)
> I'm all for unbundling but it would require that somebody is providing a
> patch. At the moment I'm simply trying to keep zulucrypt in Fedora.

What about using the bundled lxqt-wallet in zulucrypt then? It's same upstream so we could assume they know what they do.

Another option is to orphan sirikali as another relevant dependency to care about. Taking that maintainer into the boat, please feel free to assign back if you think there's no issue.

I would prefer zulucrypt to bundle lxqt-wallet, so sirikali can stay and progress.

zuluCrypt 6.0.0 available, see bug #1922201

bundled (internal) lxqt-wallet is 3 months old

zuluCrypt 6.x requires lxqt-wallet 3.2.0 at least. Thus, it looks like that the lxqt-wallet could come and wouldn't affect sirikali. It was mentioned that sirikali works with 3.2.1

Correct.