Bug 1863218

Summary: apcupsd: FTBFS in Fedora rawhide/f33
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: apcupsdAssignee: Jason Tibbitts <j>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 33CC: esandeen, germano.massullo, j, mboddu, tsmetana
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-01-30 21:17:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1803234    

Description Fedora Release Engineering 2020-08-03 15:09:39 UTC
apcupsd failed to build from source in Fedora rawhide/f33

https://koji.fedoraproject.org/koji/taskinfo?taskID=47928603


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
Please fix apcupsd at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
apcupsd will be orphaned. Before branching of Fedora 34,
apcupsd will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Ben Cotton 2020-08-11 13:53:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.

Comment 2 Germano Massullo 2020-09-26 09:14:25 UTC
EPEL branch uses the same spec file of master branch.
There, it has recently been introduced the new cmake macros [1]

%cmake OR %cmake_kf5
%cmake_build
%cmake_install

but they do not work on EL8 at the moment, so we need to add proper macros to skip them.
A good example how to handle this, is my spec file
https://src.fedoraproject.org/rpms/darktable/blob/master/f/darktable.spec

[1]: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds

Comment 3 Fedora Release Engineering 2020-09-30 18:41:15 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 33.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2020-09-28).

A week before the mass branching of Fedora 34 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 32 will be
retired regardless of the status of this bug.

[1] https://fedoraproject.org/wiki/Updates_Policy
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-34/f-34-key-tasks.html

Comment 4 Germano Massullo 2021-01-30 18:19:40 UTC
Help needed.

I created an updated spec file with new [1] cmake flags
https://download.copr.fedorainfracloud.org/results/germano/apcupsd/fedora-rawhide-x86_64/01927794-apcupsd/apcupsd.spec

but the build [2] fails:
===
cp: cannot stat '/usr/lib/rpm/config.guess': No such file or directory
cp: cannot stat '/usr/lib/rpm/config.sub': No such file or directory
===
and it's weird because the package structure has not changed, it's the same that built sccessfully on older Fedora branches

[1]: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds
[2]: https://copr.fedorainfracloud.org/coprs/germano/apcupsd/build/1927794/

Adding in CC mohanboddu that is trying to build the F34 package

Comment 5 Jason Tibbitts 2021-01-30 19:35:22 UTC
This has nothing to do with cmake; those files simply don't exist in F33+.  I'm fixing it now but waiting for a koji build to finish on all architecture.

Comment 6 Jason Tibbitts 2021-01-30 21:17:29 UTC
While fixing the build problem I went ahead and cleaned up the spec to avoid redefining %make_build and disabling the format security checks.  This has been built in rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=60924052

Comment 7 Germano Massullo 2021-01-30 21:23:50 UTC
(In reply to Jason Tibbitts from comment #6)
> While fixing the build problem I went ahead and cleaned up the spec to avoid
> redefining %make_build and disabling the format security checks.  This has
> been built in rawhide:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=60924052

I tested the new spec also on EPEL8. It builds perfectly!