Bug 1863615

Created attachment 1704443 [details]
engine.log

You can't create a VM which is set as headless (maybe coming from the HP profile) and enable console at the the same time (apparently you set VNC+SPICE). If that happened automatically we need to see the API request details.

(In reply to Michal Skrivanek from comment #2)
> You can't create a VM which is set as headless (maybe coming from the HP
> profile) and enable console at the the same time (apparently you set
> VNC+SPICE). If that happened automatically we need to see the API request
> details.

This VM is created using the API - with vm type to HP and os RHCOS. I didn't mess with the console at all

Creating a VM from the UI with HP type yields an NPE while trying to run it:


2020-08-04 12:41:14,086+03 ERROR [org.ovirt.engine.core.vdsbroker.CreateVDSCommand] (EE-ManagedThreadFactory-engine-Thread-23756) [ee0b9693-9238-4fd9-a1aa-997
8d1dcf208] Command 'CreateVDSCommand( CreateVDSCommandParameters:{hostId='d5cee641-f873-4729-b2f6-f2db7a0092e3', vmId='e2690b65-e830-432e-990c-02fb97e81656', 
vm='VM [HP-USB-FAIL]'})' execution failed: java.lang.NullPointerException
2020-08-04 12:41:14,086+03 DEBUG [org.ovirt.engine.core.vdsbroker.CreateVDSCommand] (EE-ManagedThreadFactory-engine-Thread-23756) [ee0b9693-9238-4fd9-a1aa-997
8d1dcf208] Exception: java.lang.RuntimeException: java.lang.NullPointerException
        at deployment.engine.ear//org.ovirt.engine.core.vdsbroker.CreateVDSCommand.executeVmCommand(CreateVDSCommand.java:59)
        at deployment.engine.ear//org.ovirt.engine.core.vdsbroker.ManagingVmCommand.executeVDSCommand(ManagingVmCommand.java:17)
        at deployment.engine.ear//org.ovirt.engine.core.vdsbroker.VDSCommandBase.executeCommand(VDSCommandBase.java:65)
        at org.ovirt.engine.core.dal//org.ovirt.engine.core.dal.VdcCommandBase.execute(VdcCommandBase.java:31)
        at deployment.engine.ear//org.ovirt.engine.core.vdsbroker.vdsbroker.DefaultVdsCommandExecutor.execute(DefaultVdsCommandExecutor.java:14)
        at deployment.engine.ear//org.ovirt.engine.core.vdsbroker.ResourceManager.runVdsCommand(ResourceManager.java:398)

Marking as test blocker, it prevents OCP on oVirt deployment to work.

Also marking as regression since it's working with oVirt 4.4.0

The NPE is a result of TSC. It introduced in 4.4 and didn't backport to 4.3.
The result is VDSM not reporting the TSC from the host to the engine for clusters < 4.4 and we should avoid setting TSC in that case.

As investigated, the failure regarding the USB is due missing the DELETE API requests to remove the graphic consoles of the VM.

(In reply to Sandro Bonazzola from comment #5)
> Also marking as regression since it's working with oVirt 4.4.0

you shouldn't be using 4.3 cluster level. In fully up to date setup it's supposed to be 4.4 with 4.4 clusters

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Michal, Liran, why is the engine creating graphic console if the VM is HP and should be headless? 
And by that rendering a VM which will always fail to start (I'm ignoring the NPE here, this is not the real problem)

(In reply to Roy Golan from comment #9)
> Michal, Liran, why is the engine creating graphic console if the VM is HP
> and should be headless? 
> And by that rendering a VM which will always fail to start (I'm ignoring the
> NPE here, this is not the real problem)

It is the way HP VMs were designed for safety, yes it's non-trivial.
More can be read in:
BZ 1780936#c3
https://gerrit.ovirt.org/#/c/105929/
BZ 1406394

Adding to comment 10 that not all HP VMs are necessarily headless

Liran, please check if the exception that was mentioned in the description still happens - the VM should start with VNC in this case

*** Bug 1867098 has been marked as a duplicate of this bug. ***

Related to this one: https://bugzilla.redhat.com/show_bug.cgi?id=1848922

Verified:
ovirt-engine-4.4.2.3-0.6.el8ev
vdsm-4.40.26-1.el8ev.x86_64
libvirt-daemon-6.0.0-25.module+el8.2.1+7154+47ffd890.x86_64
qemu-kvm-4.2.0-29.module+el8.2.1+7297+a825794d.x86_64

Verification scenario:
1. Create new VM with Q35 chipset and legacy BIOS.
2. Change VM to high performance VM from API. run VM.
3. Verify:
VM is running properly
Console can be opened for that VM, console USB selection is grayed out (cannot select USB device)
ssh VM and verify lsusb is not listing USB devices
           verify lspci is not listing USB controllers.
No errors in engine.log and vdsm.log
4. Repeat steps 1-3, this time for pc-i440fx and legacy BIOS.
5. Repeat steps 1-4, this time set high performance VM from WebAdmin.
step 3 note: when setting HP VM from WebAdmin, headless mode is also enabled, so console cannot be opened on such VM.
6. repeat steps 1-5, this time using 4.3 cluster.

This bugzilla is included in oVirt 4.4.2 release, published on September 17th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.