Bug 1863810

Summary:	panic: "invalid memory address or nil pointer dereference" while resyncing
Product:	OpenShift Container Platform	Reporter:	Antonio Ojea <aojeagar>
Component:	Cloud Compute	Assignee:	Danil Grigorev <dgrigore>
Cloud Compute sub component:	Other Providers	QA Contact:	sunzhaohua <zhsun>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	aos-bugs, juzhao, mfojtik
Version:	4.6
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:22:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Antonio Ojea 2020-08-03 17:27:53 UTC

Description of problem:

machine-api-operator panics after resyncing

Version-Release number of selected component (if applicable):

ocp/4.6:base

How reproducible:

Found in 

https://prow.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/709/pull-ci-openshift-cluster-network-operator-master-e2e-ovn-step-registry/1290117649933537280

Log with the panic 

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/709/pull-ci-openshift-cluster-network-operator-master-e2e-ovn-step-registry/1290117649933537280/artifacts/e2e-ovn-step-registry/gather-extra/pods/openshift-machine-api_machine-api-operator-79f8978b9b-zd55z_machine-api-operator_previous.log

Comment 2 Joel Speed 2020-08-24 11:17:08 UTC

This error[1] isn't being checked properly, causing the `existing` to be nil and leading to this panic. Handling the error properly should solve this issue. We also need to make sure we add tests for this code as it isn't tested currently.

[1]: https://github.com/openshift/machine-api-operator/blob/79ac5f8a00976701665f8cc42f324cd5a810fcd0/pkg/operator/webhook_configuration.go#L172-L177

Comment 5 sunzhaohua 2020-09-22 02:55:08 UTC

From the test result, didn't meet this again, move this to verified.
https://prow.ci.openshift.org/pr-history/?org=openshift&repo=machine-api-operator&pr=684

Comment 7 errata-xmlrpc 2020-10-27 16:22:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196