Bug 1865701

Summary: request re-addition of 'posttls-finger' bin to postfix pkg
Product: [Fedora] Fedora Reporter: pgnet.dev
Component: postfixAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 32CC: jskarvad, olysonek
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: postfix-3.5.6-2.fc33 postfix-3.5.6-2.fc32 postfix-3.5.9-3.eln110 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-06 22:08:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description pgnet.dev 2020-08-03 22:13:33 UTC
postfix provides 'posttls-finger' tool ,

	http://www.postfix.org/posttls-finger.1.html

although it does state

	"Note:  this is an unsupported test program. No attempt is made to maintain compatibility between successive versions."

it's a useful diagnostic, and oft-referenced on the upstream ML.

it's included in current source,

	cd src/posttls-finger/
	tree
		├── Makefile
		├── Makefile.in
		├── posttls-finger
		├── posttls-finger.c
		├── posttls-finger.o
		├── tlsmgrmem.c
		├── tlsmgrmem.h
		└── tlsmgrmem.o

it's also included in other distros', some separately pkg's, e.g.,

	https://manpages.debian.org/unstable/postfix/posttls-finger.1.en.html


it's in fact mentioned in the Fedora pkg chglog; last @

	https://src.fedoraproject.org/rpms/postfix/blob/master/f/postfix.spec#_895

		* Mon Dec  3 2018 Jaroslav Škarvada <jskarvad>
		- 2:3.3.1-7- Fixed posttls-finger to work with unix domains

but, here, on F32,

	 rpm -qa | grep postfix
		postfix-3.5.4-2.fc32.x86_64
		postfix-lmdb-3.5.4-2.fc32.x86_64
		postfix-mysql-3.5.4-2.fc32.x86_64
		postfix-pcre-3.5.4-2.fc32.x86_64
		postfix-perl-scripts-3.5.4-2.fc32.x86_64
		postfix-sqlite-3.5.4-2.fc32.x86_64

it's gone missing

	rpm -ql `rpm -qa | grep postfix | egrep -i "tls|finger"
		/usr/lib64/postfix/libpostfix-tls.so
		/usr/libexec/postfix/postfix-tls-script
		/usr/libexec/postfix/tlsmgr
		/usr/libexec/postfix/tlsproxy
		/usr/share/doc/postfix/README_FILES/TLS_LEGACY_README
		/usr/share/doc/postfix/README_FILES/TLS_README
		/usr/share/doc/postfix/TLS_ACKNOWLEDGEMENTS
		/usr/share/doc/postfix/TLS_LICENSE
		/usr/share/man/man1/postfix-tls.1.gz
		/usr/share/man/man8/tlsmgr.8.gz
		/usr/share/man/man8/tlsproxy.8.gz

requesting that it be re-added

fyi, it builds/installs/functions cleanly, locally, against current upstream sources

Comment 1 Jaroslav Škarvada 2020-08-06 20:05:21 UTC
I think it wasn't removed from Fedora. It's not installed by default by the postfix install script, i.e. it seems upstream doesn't want it to be installed by default. But I don't have problem to install it by hand as we do with some other postfix tools.

Comment 2 pgnet.dev 2020-08-06 20:36:37 UTC
> I think it wasn't removed from Fedora

hm.  odd.  was the "Fixed posttls-finger to work with unix domains" commit log perhaps NOT for Fedora, but for RH/Centos?

in any case, looking at my local from-source build script, it appears it's _built_ by default with

 make V=1 -j4 DEBUG="" OPT="-O3"
 make upgrade mail_owner=postfix setgid_group=postdrop

but, as you point out, not in fact _installed_ by default, needing a simple

 cp -af \
  /usr/local/src/postfix-${POSTFIX_VER}/bin/posttls-finger \
  /usr/local/sbin/posttls-finger

it _is_ a helpful tool, and would be useful to have it pkg'd.

if adding it to the default pkgs doesn't 'fit', perhaps adding to a 'postfix-extras', or similar, pkg?

Comment 3 Jaroslav Škarvada 2020-08-06 21:11:06 UTC
(In reply to pgnet.dev from comment #2)
> > I think it wasn't removed from Fedora
> 
> hm.  odd.  was the "Fixed posttls-finger to work with unix domains" commit
> log perhaps NOT for Fedora, but for RH/Centos?
>
The changelog wasn't clear about it. IIRC I fixed the code and sent the patch upstream, because we found the problem during some source code audit (IIRC Coverity scan) but we didn't install the tool.

> in any case, looking at my local from-source build script, it appears it's
> _built_ by default with
> 
>  make V=1 -j4 DEBUG="" OPT="-O3"
>  make upgrade mail_owner=postfix setgid_group=postdrop
> 
> but, as you point out, not in fact _installed_ by default, needing a simple
> 
>  cp -af \
>   /usr/local/src/postfix-${POSTFIX_VER}/bin/posttls-finger \
>   /usr/local/sbin/posttls-finger
> 
> it _is_ a helpful tool, and would be useful to have it pkg'd.
> 
> if adding it to the default pkgs doesn't 'fit', perhaps adding to a
> 'postfix-extras', or similar, pkg?

No problem I will add it to the base postfix package, we already have some other diagnostic tools there.

Comment 4 Fedora Update System 2020-08-06 22:08:12 UTC
FEDORA-2020-79299632f5 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2020-08-06 22:29:55 UTC
FEDORA-2020-926f65859e has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-926f65859e

Comment 6 Fedora Update System 2020-08-07 01:03:52 UTC
FEDORA-2020-926f65859e has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-926f65859e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-926f65859e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-08-09 02:18:19 UTC
FEDORA-2020-926f65859e has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2021-02-11 08:30:40 UTC
FEDORA-2021-5c52900493 has been pushed to the Fedora ELN stable repository.
If problem still persists, please make note of it in this bug report.