Bug 1865990
| Summary: | storage: tests_luks.yml partition case failed with nvme disk | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Zhang Yi <yizhan> |
| Component: | rhel-system-roles | Assignee: | Pavel Cahyna <pcahyna> |
| Status: | CLOSED ERRATA | QA Contact: | Zhang Yi <yizhan> |
| Severity: | unspecified | Docs Contact: | Eliane Ramos Pereira <elpereir> |
| Priority: | high | ||
| Version: | 8.3 | CC: | bubrown, djez, dlehman, guazhang, japokorn, pcahyna |
| Target Milestone: | beta | Keywords: | Triaged |
| Target Release: | 8.4 | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | role:storage | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
.`tests_luks.yml` no longer cause partition case fail with NVME disk
Previously, NVME disks used a different partition naming convention than the one used by `virtio/scsi` and the Storage role did not reflect it. As a consequence, running the Storage role with NVME disks resulted in a crash. With this fix, the Storage RHEL System Role now obtains the partition name from the `blivet` module.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-05-18 16:02:26 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
It is not related to LUKS, correct? By the way, is there a way to reproduce the problem without using an actual nvme device, like in the VMs used in the CI? (In reply to Pavel Cahyna from comment #1) > It is not related to LUKS, correct? By the way, is there a way to reproduce > the problem without using an actual nvme device, like in the VMs used in the > CI? Yes, it also can be reproduced with bellow playbook, currently I've no idea how to reproduce it without an actual nvme device. I saw David already have an fix for it, maybe he have more hints for the root cause and idea to reproduce in VMs. If not, maybe we can consider enable nvme disk in VMs. ``` --- - hosts: all become: true vars: storage_safe_mode: false mount_location: '/opt/test1' volume_size: '5g' tasks: - include_role: name: storage - include_tasks: get_unused_disk.yml vars: min_size: "{{ volume_size }}" max_return: 1 ## ## Partition ## - name: Create an encrypted partition volume w/ default fs include_role: name: storage vars: storage_pools: - name: foo type: partition disks: "{{ unused_disks }}" volumes: - name: test1 type: partition mount_point: "{{ mount_location }}" # size: 4g - include_tasks: verify-role-results.yml - name: Remove the encryption layer include_role: name: storage vars: storage_pools: - name: foo type: partition disks: "{{ unused_disks }}" volumes: - name: test1 type: partition mount_point: "{{ mount_location }}" # size: 4g - include_tasks: verify-role-results.yml - name: Clean up include_role: name: storage vars: storage_pools: - name: foo type: partition disks: "{{ unused_disks }}" - include_tasks: verify-role-results.yml ``` The problem is one of predicting the names of partitions on nvme drives, where they use a different formula than on scsi/virtio. So any test case that uses partitions will likely hit this. Do we actually document partition pools as supported?
> The problem is one of predicting the names of partitions on nvme drives, where they use a different formula than on scsi/virtio
And what about multipath, will it also use a different formula than scsi/virtio/(ata)?
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:1909 |
Description of problem: storage: tests_luks.yml failed with nvme disk Version-Release number of selected component (if applicable): How reproducible: rhel-system-roles-1.0-12.el8.noarch Steps to Reproduce: 1. run bellow playbook with NVMe disk 2. 3. Actual results: Expected results: Additional info: It failed on Partition cases, and passed on DISK/LVM cases # cat tests_luks.yml --- - hosts: all become: true vars: storage_safe_mode: false mount_location: '/opt/test1' volume_size: '5g' tasks: - include_role: name: storage - include_tasks: get_unused_disk.yml vars: min_size: "{{ volume_size }}" max_return: 1 ## ## Partition ## - name: Create an encrypted partition volume w/ default fs include_role: name: storage vars: storage_pools: - name: foo type: partition disks: "{{ unused_disks }}" volumes: - name: test1 type: partition mount_point: "{{ mount_location }}" # size: 4g encryption: true encryption_passphrase: 'yabbadabbadoo' - include_tasks: verify-role-results.yml - name: Remove the encryption layer include_role: name: storage vars: storage_pools: - name: foo type: partition disks: "{{ unused_disks }}" volumes: - name: test1 type: partition mount_point: "{{ mount_location }}" # size: 4g encryption: false encryption_passphrase: 'yabbadabbadoo' - include_tasks: verify-role-results.yml