Bug 1866291

Summary:	EPN: enhance input validation
Product:	Red Hat Enterprise Linux 8	Reporter:	François Cami <fcami>
Component:	ipa	Assignee:	François Cami <fcami>
Status:	CLOSED ERRATA	QA Contact:	ipa-qe <ipa-qe>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.3	CC:	ksiddiqu, rcritten, sumenon, tscherf, twoerner
Target Milestone:	rc	Keywords:	TestCaseProvided
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ipa-4.8.7-9.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-04 02:51:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description François Cami 2020-08-05 10:31:36 UTC

This bug is created as a clone of upstream ticket:
https://pagure.io/freeipa/issue/8444

### Issue
ipa-epn does not check its input for:
- decimal numbers or alpha characters in --from-nbdays/--to-nbdays
-  --from-nbdays > --to-nbdays

Comment 1 François Cami 2020-08-05 10:33:04 UTC

WIP PR: https://github.com/freeipa/freeipa/pull/4991

Comment 4 Rob Crittenden 2020-08-10 13:18:02 UTC

This also depends on changes in https://pagure.io/freeipa/issue/8449

master:
https://pagure.io/freeipa/c/e1750e2a18ed0e537608cfdee7eed3ffa090d443
https://pagure.io/freeipa/c/41333b631d3ffa8d32d5bd5c2b69f2f51bb62c21

ipa-4-8:
https://pagure.io/freeipa/c/9479a393a71fe1de7d62ca2b50a7d3d8698d4ba1
https://pagure.io/freeipa/c/3b8fdd87760cfb8ec739c67298f012cf0bd3ac39

Comment 5 Rob Crittenden 2020-08-11 13:14:39 UTC

From 8449:

master:
https://pagure.io/freeipa/c/e1750e2a18ed0e537608cfdee7eed3ffa090d443
https://pagure.io/freeipa/c/41333b631d3ffa8d32d5bd5c2b69f2f51bb62c21

ipa-4-8:
https://pagure.io/freeipa/c/9479a393a71fe1de7d62ca2b50a7d3d8698d4ba1
https://pagure.io/freeipa/c/3b8fdd87760cfb8ec739c67298f012cf0bd3ac39

Comment 6 François Cami 2020-08-11 22:31:49 UTC

https://github.com/freeipa/freeipa/pull/4991 is not merged yet.

Comment 7 Rob Crittenden 2020-08-12 13:03:25 UTC

Fixed upstream
master:
https://pagure.io/freeipa/c/97006786dfed7947aaa96737201ef7e0e53dd952
https://pagure.io/freeipa/c/5452f020f93d57a48c4ae34675cc7e480b66fccf

Comment 8 Rob Crittenden 2020-08-12 13:05:15 UTC

Upstream ticket:
https://pagure.io/freeipa/issue/8449

Comment 9 Rob Crittenden 2020-08-17 13:37:09 UTC

Fixed upstream
ipa-4-8:
https://pagure.io/freeipa/c/b4266023e04729db12de2f7e0de4da9e1d00db38
https://pagure.io/freeipa/c/2809084a44e3b174fa48a611e79f04358e1d6dca

Comment 12 Kaleem 2020-08-19 17:55:05 UTC

With following IPA version (4.8.7.9.module+el8.3.0+7664+fa35cfe6), tests test_EPN_nbdays_input[0-4] and test_EPN_nbdays_[0-1] are successful, so moving the bug to verified. Refer attached report.html for detailed test results.

2020-08-19T15:27:47+0000 ok: [master.testrealm.test] => (item=ipa-server) => 
2020-08-19T15:27:47+0000   msg:
2020-08-19T15:27:47+0000   - arch: x86_64
2020-08-19T15:27:47+0000     epoch: null
2020-08-19T15:27:47+0000     name: ipa-server
2020-08-19T15:27:47+0000     release: 9.module+el8.3.0+7664+fa35cfe6
2020-08-19T15:27:47+0000     source: rpm
2020-08-19T15:27:47+0000     version: 4.8.7

Comment 16 errata-xmlrpc 2020-11-04 02:51:20 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: idm:DL1 and idm:client security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4670