Bug 1867047

Summary:	Patch pppd to handle Windows Server 2019 non-compliant success packets
Product:	[Fedora] Fedora	Reporter:	Douglas Kosovic <doug>
Component:	ppp	Assignee:	Jaroslav Škarvada <jskarvad>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jaskalnik, jskarvad, jsynacek, msekleta, thozza
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ppp-2.4.8-8.fc33 ppp-2.4.8-8.eln103	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-10 17:57:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Douglas Kosovic 2020-08-07 08:55:35 UTC

Description of problem:
Recently Windows Server 2019 has started producing non-complaint PPP success packets which have a space missing before the M= in the packet.

The following recent upstream patch handles the missing-space non-compliant success packets:

https://github.com/paulusmack/ppp/commit/3cd95baf3f1de1d5a9bc89be0f4c3215ceb5aefe.patch

Comment 1 Douglas Kosovic 2020-08-07 08:57:04 UTC

macOS already handles the missing space before M=, extract from :
https://opensource.apple.com/source/ppp/ppp-862.120.2/Helpers/pppd/chap_ms.c.auto.html

	//we'll allow the missing-space case from the server, even though
	//it's non-conforming to spec!
	dbglog("Rcvd non-conforming MSCHAPv2 Success packet, len=%d", len);
	if(len >= 2 && !strncmp((char*)msg, "M=", 2))
		msg += 2;
	else
	{
		error("MS-CHAPv2 Success packet is badly formed.");
		return 0;
	}

Comment 2 Jaroslav Škarvada 2020-08-10 16:15:48 UTC

Thanks for info, I don't have problem to use the patch downstream till new release will happen.

Comment 3 Fedora Update System 2020-08-10 17:57:04 UTC

FEDORA-2020-d2701dc1ba has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Fedora Update System 2020-08-10 18:06:07 UTC

FEDORA-2020-e60af8e398 has been pushed to the Fedora ELN stable repository.
If problem still persists, please make note of it in this bug report.