Bug 1867329
| Summary: | Review Request: R-RcppDate - 'date' C++ Header Library for Date and Time Functionality | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elliott Sales de Andrade <quantum.analyst> |
| Component: | Package Review | Assignee: | José Matos <jamatos> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jamatos, package-review |
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-09-08 15:13:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Elliott Sales de Andrade
2020-08-08 21:27:38 UTC
The spec file is simple and correct. I have just one doubt where is the bundled date? I examined both rpms and I cannot find it. The devel package should have date.h and tz.h, which are both from date-devel. I think the other headers are also from date, but maybe a different version. I think that you are being too strict about the bundle. IMHO at most it should be bundled(date-devel) since there is no binary or library distributed for (raw) date. In any case this is a minor issue. So the usual template applies here: The spec file is sane. The license is correct and the package builds and install in rawhide. The package is approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-RcppDate FEDORA-2020-f2c2d6ad2a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f2c2d6ad2a FEDORA-2020-b1843ef5d0 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b1843ef5d0 FEDORA-2020-f2c2d6ad2a has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-f2c2d6ad2a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f2c2d6ad2a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-b1843ef5d0 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-b1843ef5d0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b1843ef5d0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-f2c2d6ad2a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f2c2d6ad2a FEDORA-2020-f2c2d6ad2a has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-f2c2d6ad2a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f2c2d6ad2a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-b1843ef5d0 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-f2c2d6ad2a has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. |