Bug 1867400

Description of problem (please be detailed as possible and provide log
snippests):
----------------------------------------------------------------------
UI allows creation of a second StorageCluster of a different mode which should be blocked. The 2nd Storagecluster is in IGNORED state but with no suitable message for the same. This can be confusing to the users

Either we should completely block a new storagecluster creation in case one already exists or we should have a proper reasoning for the IGNORED state of the 2nd SCluster. Otherwise, users might not undertsand the reason of the newly created Scluster to be in IGNORED state

Not sure if this is a bug in ocs-operator or management-console, hence raising it in management-console for the start

>> These are the various observations from multiple scenarios


>> 1. Storagecluster1 : Mode = Internal , Storagecluster2: Mode= External 

   1a) Storagecluster2 Creation succeeds and is not blocked from UI. But the Storagecluster is in Ignored state

>> 2. Storagecluster1 : Mode = external , Storagecluster2: Mode= Internal

   1a) Storagecluster2 Creation succeeds and is not blocked from UI. But, as expected, the Storagecluster is in Ignored state


>> 3. Try creating a second Storagecluster of same mode type: (This is rejected in UI itself)

   1a) If Storagecluster1:Mode = Internal, Creating 2nd storagecluster with same mode throws error due [storageclusters.ocs.openshift.io "ocs-storagecluster" already exists]
   1b) If Storagecluster1:Mode = external, Creating storagecluster2 with same mode throws error due to [secret "rook-ceph-external-cluster-details" already exists]

   1c) try creating from CLI with a different name, Storagecluster creation succeeds but enters "Ignored" state

Snip of the outputs
======================

for #1
$ oc get storagecluster
NAME                          AGE    PHASE     EXTERNAL   CREATED AT             VERSION
ocs-external-storagecluster   46h    Ignored   true       2020-08-07T18:01:58Z   
ocs-storagecluster            3d2h   Ready                2020-08-06T13:45:06Z   4.5.0

$ oc describe storagecluster ocs-external-storagecluster

Status:
  Phase:  Ignored
Events:   <none>


Version of all relevant components (if applicable):
----------------------------------------------------------------------
OCP  = 4.5.0-0.nightly-2020-08-07-024812

OCS = ocs-operator.v4.5.0-515.ci

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
----------------------------------------------------------------------
No

Is there any workaround available to the best of your knowledge?
----------------------------------------------------------------------
No. The UI doesnt reject the 2nd storagecluster creation


Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
----------------------------------------------------------------------
2

Can this issue reproducible?
----------------------------------------------------------------------
Yes

Can this issue reproduce from the UI?
----------------------------------------------------------------------
Yes

If this is a regression, please provide more details to justify this:
----------------------------------------------------------------------
No. But new modes(Internal & external) are introduced from current OCS 4.5 release onwards

Steps to Reproduce:
----------------------------------------------------------------------
1. Create an OCS cluster with any appropriate mode ,  e.g. Internal
2. Try to create a second Storagecluster with another mode, e.g. external
 Installed Operators-> OCS Operator->Storage Cluster-> Create New Storage Cluster Service-> Select a different Mode than existing Storagecluster

Actual results:
----------------------------------------------------------------------
UI doesn't block creation of the 2nd storagecluster, even though ultimately PHASE= IGNORED


Expected results:
----------------------------------------------------------------------
UI should block creation of 2nd storagecluster. and if that cannot be achieved, atleast proper UI message(this cluster will be in IGNORED state) and description should be added for "Ignored" state

Additional info:
----------------------------------------------------------------------


$ oc describe storagecluster ocs-external-storagecluster
Name:         ocs-external-storagecluster
Namespace:    openshift-storage
Labels:       <none>
Annotations:  <none>
API Version:  ocs.openshift.io/v1
Kind:         StorageCluster
Metadata:
  Creation Timestamp:  2020-08-07T18:01:58Z
  Generation:          1
  Managed Fields:
    API Version:  ocs.openshift.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        .:
        f:externalStorage:
          .:
          f:enable:
        f:labelSelector:
    Manager:      Mozilla
    Operation:    Update
    Time:         2020-08-07T18:01:58Z
    API Version:  ocs.openshift.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        f:version:
      f:status:
        .:
        f:phase:
    Manager:         ocs-operator
    Operation:       Update
    Time:            2020-08-07T18:01:58Z
  Resource Version:  958967
  Self Link:         /apis/ocs.openshift.io/v1/namespaces/openshift-storage/storageclusters/ocs-external-storagecluster
  UID:               56dacde5-b94c-4b6d-a9ac-855b85dc8094
Spec:
  External Storage:
    Enable:  true
  Label Selector:
    Match Expressions:
Status:
  Phase:  Ignored
Events:   <none>