Bug 186811

This is the 1st prerequisite to conntrack userspace tool. Second will be
libnfnetlink_conntrack.

Good:
+ Local build works.
+ rpmlint has not complaints for SRPM.
+ Mock build worked fine.

Bad:
- rpmlint complaints on libnfnetlink:
  E: libnfnetlink library-without-ldconfig-postin /usr/lib/libnfnetlink.so.0.0.0
  E: libnfnetlink library-without-ldconfig-postun /usr/lib/libnfnetlink.so.0.0.0
- rpm don't contains verbatin copy of the license.
- devel rpm contains static libraries.

I've updated spec and srpm wrt ldconfig and --disable-static.
And wrt license text - original distribution don't contain it too.

Unfortunately I can't judge about the spec in detail. But I did build and try
the three related packages (libnfnetlink, libnetfilter_conntrack and conntrack).
They did build and install fine, conntrack seems to work fine as well.

Please bump the release number with package revision, even during review. The
SRPM at the posted URL does not contain the same spec file as the one at the
posted spec URL (still missing ldconfig scriptlets).

http://stingr.net/l/fe/libnfnetlink.spec
http://stingr.net/l/fe/libnfnetlink-0.0.14-2.src.rpm

Please take the license text from www.gnu.org an poke the upstream to include a
written license text.

Is it serious, real, critical showstopper? It wil enhance review period for
another couple of weeks because of "upstream" being on vacation.

(In reply to comment #8)
> Is it serious, real, critical showstopper? It wil enhance review period for
> another couple of weeks because of "upstream" being on vacation.

No, it's not a blocker. It's a "SHOULD" in the package review guidelines
(http://fedoraproject.org/wiki/Packaging/ReviewGuidelines).

You may be able to download the current CPL text from 
http://www.gnu.org/licenses/gpl.txt and add is to your package.

Then you may poke the upstream to include a verbatin copy of the license in 
the upstream package.

When this may be happen, you can create an updated version of your package, 
which use the text from the upstream package instead of the text from 
www.gnu.org

So to my understanding there is nothing really preventing a release in extras,
since the gpl-text can be added to the package without it being upstream as well
for now. Or is there something I could do to actually move this topic (release
in extras) forward?

(In reply to comment #11)
> So to my understanding there is nothing really preventing a release in extras,
> since the gpl-text can be added to the package without it being upstream as well
> for now. Or is there something I could do to actually move this topic (release
> in extras) forward?

Jochen is asking you to include http://www.gnu.org/licenses/gpl.txt as an
additional source file, to include this file as %doc in your spec, and also to
try to get upstream to include a copy of the license text distributed with their
source. Whilst there is no requirement in the package review guidelines for the
license text to be packaged if upstream do not provide it, and poking upstream
is only a *should* rather than a *must* in the guidelines, if you want to get
this package approved sooner rather than later, I'd do as Jochen asks.

http://stingr.net/l/fe/libnfnetlink.spec
http://stingr.net/l/fe/libnfnetlink-0.0.14-3.src.rpm

I'm happy to APPOROVE your package.

(In reply to comment #14)
> I'm happy to APPOROVE your package.

Please do block FE-ACCEPT when you approve a package.
Thanks.

Package Change Request
======================
Package Name: libnfnetlink
New Branches: EL-4 EL-5
Owners: stingray jrussek

jrussek doesn't seem to be in the packager group. 

Please add a new request and reset the flag?

Package Change Request
======================
Package Name: libnfnetlink
New Branches: EL-6
Owners: stingray jrussek

jrussek still isn't in the packager group.  What Kevin meant was submit a new request, either after jrussek is in the packager group, or without jrussek.

Package Change Request
======================
Package Name: libnfnetlink
New Branches: EL-4 EL-5 EL-6
Owners: stingray

Git done (by process-git-requests).