Bug 186813

rpmlint gives an error about the sgid games bit on the binary, this however is
intentional, its needed for access to the shared hiscore file.

Also see njam-1.25-drop-setgid.patch. The first thing done in main is opening
the file, the second is dropping the gid games rights, 100% safe.

I'll take a look at this shortly.  The premise of the game sounds strikingly
similar to something that I use to play 20 years ago...

It is somewhat similar to *that* game yes. I noticed I forgot to add
desktop-file-utils to the BR. I've uploaded a new version over the previous -1
with this fixed.

MUST
====
* rpmlint complains about the setgid binary.  This is acceptable per
  the Games SIG recommendation regarding scoreboard files.
* Package and spec file named appropriately
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
    231fda022d309e1ef4a0d993ca693462  njam-1.25-src.tar.gz
* Compiles and builds on FC5-i386 and in mock on FC4-x86_64, FC4-i386
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Permissions ok
* %doc does not affect runtime
* Contains code and permissible content
* No -devel package
* .desktop file included
* Directory ownership ok 

MUSTFIX
=======
* Some of the wording and capitalization in the %description is a little
  awkward.  I suggest the following:
"Njam is a fast-paced maze-game where you must eat all the cookies while
avoiding the badguys. Special cookies give you the power to freeze or eat the
bad guys. The game features single and multiplayer modes, network play,
duelling and cooperative games, great music and sound effects, customizable
level skins, many different levels and an integrated level editor." 

* Man pages for games should go in %{mandir}/man6 according to the FHS:
  http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES
  This also needs to be mentioned on the Games SIG wiki page (I'll add it
  shortly)

* The summary, %description, and njam.1 file should refer to cookies instead of
  dots.  This is how they are described on the home page.

RECOMMENDED
===========
* For a nicer looking icon, make the background transparent:
    convert -transparent black njamicon.ico %{name}.png

* The "Home" link in the upper-right of the doc-editor.html file points to
  a nonexistant index.html file.

Cool & Thanks, I'll look into both the MUSTFIX and RECOMMENDED tomorrow as time
permits.

In the mean time if you've got time you could take a look at the other classic
inspired game I've just submitted for review, see the games sig page.

I've fixed all MUSTFIX and RECOMMENDED items. I've used the description you
provided for %description and the man page. New version:
Spec Name or Url: http://home.zonnet.nl/jwrdegoede/njam.spec
SRPM Name or Url: http://home.zonnet.nl/jwrdegoede/njam-1.25-2.src.rpm

I don't want to seem impatient, let alone rude, but ...  ping?

Looks good.  Only the man page still says "NJAM(1)" at the top when I run "man
njam".  It should read "NJAM(6)".  To fix, change line 54 in njam.6 to:
.TH "NJAM" "6"

This isn't a blocker, but should be fixed after importing.

APPROVED.

Imported, manpage fixed and build, Thanks!

using this package it is impossible to create new levels using the built-in level-editor

well, you can create them, but they aren't saved although there is is no error message

e0126505.ac.at

1) Thanks for reporting this
2) Please use a Real Name as Real Name or atleast an alias, so people have some
way of addressing you in comments
3) Please report this in a seperate bug where it belongs.

did you try pressing s to save it or a for save as before exiting the editor?

>Please report this in a seperate bug where it belongs.
#188078 

>did you try pressing s to save it or a for save as before exiting the editor?
both methods don't work...well they can't possibly work since the "levels" directory is root-owned?!