Bug 1868194

Summary:	AWS provider: set proper instance tags on update
Product:	OpenShift Container Platform	Reporter:	Michael Gugino <mgugino>
Component:	Cloud Compute	Assignee:	Alberto <agarcial>
Cloud Compute sub component:	Other Providers	QA Contact:	sunzhaohua <zhsun>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified
Version:	4.6
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:28:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Gugino 2020-08-11 23:59:44 UTC

Description of problem:

On all currently released version (versions prior to 4.6), it is possible for users to create machines that specify instance tags which will overwrite the Name and ClusterID tags.  This results in a number of problems.

One such problem is that the openshift-installer will not be able to properly clean up any instances that are created with these tags.  We should prevent this from happening.

We should build logic to always enforce the proper tags are present on instances.

Comment 3 sunzhaohua 2020-08-27 09:56:53 UTC

verified
clusterversion: 4.6.0-0.nightly-2020-08-26-010422

create new machineset with invalid tags:
          tags:
          - name: kubernetes.io/cluster/zhsun826aws-db78r-invalid
            value: owned-invalid
          - name: Name
            value: owned-invalid

destroy cluaster, all instances could be deleted.

Comment 5 errata-xmlrpc 2020-10-27 16:28:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196