Bug 1868231

Summary:	Improve thin_check to automatically repair metadata leaks or underfull btree nodes
Product:	Red Hat Enterprise Linux 7	Reporter:	Jonathan Earl Brassow <jbrassow>
Component:	device-mapper-persistent-data	Assignee:	Ming-Hung Tsai <mtsai>
Status:	CLOSED WONTFIX	QA Contact:	Lin Li <lilin>
Severity:	unspecified	Docs Contact:
Priority:	low
Version:	7.7	CC:	agk, heinzm, lilin, lvm-team, msnitzer, thornber
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-02 14:47:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1834944, 1868235
Bug Blocks:

Description Jonathan Earl Brassow 2020-08-12 05:06:48 UTC

Bug 1834944 has been split into two parts:

PART 1: Bug 1834944 will now only address the need to designate 'underfull btree nodes' as a non-fatal error.  Currently, the 'metadata leak' error is already non-fatal.  Thus, with the underfull fix and by setting '--ignore-non-fatal-errors' as a thin_check option in lvm.conf, customers will be able to boot and activate their systems without being forced to run a repair

PART 2: This bug will address the desire to have thin_check automatically repair these non-fatal errors during the check process - cleansing the metadata, if desired.  This step is unnecessary for correct operation of thin-p and is thus considered low priority; but may accompany another fix (e.g. Bug 1490517).

Comment 2 Ming-Hung Tsai 2020-08-18 09:10:57 UTC

Patches were upstreamed. Now thin_check fixes metadata leaks and the needs_check flag, if the --auto-repair option is provided, and no errors was found in the metadata.

thin_check --auto-repair {device|file}

The feature is available since v0.9.0 release.

Note: Combining fixing options (--auto-repair or --clear-needs-check-flag) with --ignore-non-fatal-error is not allowed.