Bug 1868378

Summary: metrics role: pcp/pmproxy does not automatically start
Product: Red Hat Enterprise Linux 8 Reporter: Jan Kurik <jkurik>
Component: rhel-system-rolesAssignee: Pavel Cahyna <pcahyna>
Status: CLOSED ERRATA QA Contact: Jan Kurik <jkurik>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.3CC: agerstmayr, djez, nathans
Target Milestone: rcKeywords: Rebase
Target Release: 8.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: role:metrics
Fixed In Version: rhel-system-roles-1.0-18.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 04:03:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
tests_fullstack.yml
none
pmproxy.yml none

Description Jan Kurik 2020-08-12 12:54:05 UTC 
Description of problem:
Having a playbook with "metrics_query_service: yes" or "metrics_graph_service: yes" installs and configures pcp/pmproxy, but does not start the pmproxy service.

Version-Release number of selected component (if applicable):
* RHEL-8.3.0-20200701.2
* pcp-5.1.1-3.el8
* rhel-system-roles-1.0-16.el8

How reproducible:
* always

Steps to Reproduce:
1. Install rhel-system-roles-1.0-16.el8 and ansible
2. Run a playbook using "linux-system-roles.metrics" role having set variable "metrics_query_service: yes" and/or "metrics_graph_service: yes". An example of such a playbook is attached to this bug (see "tests_fullstack.yml").

Actual results:
pmproxy service is installed and configured, but not started

Expected results:
The "linux-system-roles.metrics" with set variables "metrics_query_service: yes" or "metrics_graph_service: yes" should install configure and start the following services:
* pmcd
* pmlogger
* pmie
* pmproxy
* redis
* grafana-server

Additional info:
The issue IMO is in pmproxy.yml tasks file, which is missing explicit start of the pmproxy service. I am attaching fixed pmproxy.yml file to this bug.
Comment 1 Jan Kurik 2020-08-12 12:57:07 UTC 
Created attachment 1711182 [details]
tests_fullstack.yml
Comment 2 Jan Kurik 2020-08-12 12:57:33 UTC 
Created attachment 1711183 [details]
pmproxy.yml
Comment 3 Jan Kurik 2020-08-17 15:10:39 UTC 
Hi Nathan, can you please confirm the problem and whether you can provide a fix?
Comment 5 Nathan Scott 2020-08-18 02:51:23 UTC 
Yep, good catch Jan!

And I believe fix is correct too except for a minor cut+paste problem where it mentions pmie in the description instead of pmproxy.
I'll update that and get this merged in the upstream repositories today.
Comment 6 Nathan Scott 2020-08-18 04:04:28 UTC 
This is the following commit in linux-system-roles/metrics:

commit ed19969e9045916518e6d4eb3f363eb3e2e01c2f
Author: Jan Kurik <jkurik>
Date:   Tue Aug 18 14:03:26 2020 +1000

    Ensure pmproxy service is enabled and started when requested
    
    Resolves Red Hat BZ #1868378
Comment 9 Jan Kurik 2020-08-31 11:02:38 UTC 
Verified on rhel-system-roles-1.0-19.el8 build.
Comment 12 errata-xmlrpc 2020-11-04 04:03:58 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4809