Bug 1868695
| Summary: | colordiff -y not outputting color on CentOS 7 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Alejandro <alejandro.colon> | ||||||||||||
| Component: | colordiff | Assignee: | Richard Fearn <richardfearn> | ||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||
| Priority: | unspecified | ||||||||||||||
| Version: | epel7 | CC: | richardfearn | ||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Target Release: | --- | ||||||||||||||
| Hardware: | x86_64 | ||||||||||||||
| OS: | Linux | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Fixed In Version: | colordiff-1.0.19-1.el7 | Doc Type: | If docs needed, set a value | ||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||
| Clone Of: | Environment: | ||||||||||||||
| Last Closed: | 2020-08-31 16:28:28 UTC | Type: | Bug | ||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||
| Documentation: | --- | CRM: | |||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||
| Embargoed: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Alejandro
2020-08-13 13:56:00 UTC
Could you attach JSON files that can be used to reproduce the problem? (I do get coloured output from `colordiff -y --left-column <file1> <file2>`, connecting from Windows 10 to a CentOS 7 VM, using PuTTY 0.74.) I agree that 1.0.13 is ancient though... I'll see about getting it updated. Created attachment 1711347 [details]
File1a for testing
This is the location on my system in case that has something to do with it.
/opt/projects/openidm/subscribers/conf/authenication.json
Created attachment 1711348 [details]
File2a for testing
This is the location of the file on my system in case that has anything to do with it.
/opt/projects/git/subscribers/conf/authentication.json
Created attachment 1711350 [details]
File1b for testing
This is the location of the file on my system in case that has anything to do with it.
/opt/projects/openidm/subscribconsole.json
Created attachment 1711351 [details]
File2b for testing
This is the location on my system in case that has anything to do with it.
/opt/subscribers/conf/felix.webconsole.json
(In reply to Richard Fearn from comment #1) > Could you attach JSON files that can be used to reproduce the problem? (I do > get coloured output from `colordiff -y --left-column <file1> <file2>`, > connecting from Windows 10 to a CentOS 7 VM, using PuTTY 0.74.) > > I agree that 1.0.13 is ancient though... I'll see about getting it updated. I have attached 2 sets of files for testing. On my system both do not output color with the following commands: \colordiff -y --left-column /opt/projects/openidm/subscribers/conf/authentication.json /opt/projects/git/subscribers/conf/authentication.json \colordiff -y --left-column /opt/projects/openidm/subscribers/conf/felix.webconsole.json /opt/projects/git/subscribers/conf/felix.webconsole.json But, they do output color when adding the `--suppress-common-lines` option as below. \colordiff -y --left-column --suppress-common-lines /opt/projects/openidm/subscribers/conf/authentication.json /opt/projects/git/subscribers/conf/authentication.json \colordiff -y --left-column --suppress-common-lines /opt/projects/openidm/subscribers/conf/felix.webconsole.json /opt/projects/git/subscribers/conf/felix.webconsole.json Do not worry about the contents of the files as they are part of a course I am taking. They were one time use and have already been changed. Thanks for the attachments - I can see the issue with the JSON files (attachment.json). The `--left-column` option causes it to output `(` on each line that's the same on both sides. Looks like colordiff was fixed to recognise this in https://github.com/daveewart/colordiff/commit/bd7ee1160997a8dc89645ef627f217b17a33d9d9. 1.0.14 was the first version to include that change. Glad I was able to help narrow down the issue. I look forward to the newer version. Do I need to do anything else with this bug report? (In reply to Alejandro from comment #8) > Glad I was able to help narrow down the issue. > I look forward to the newer version. > > Do I need to do anything else with this bug report? No, leave it as-is and it'll get closed when the colordiff update goes out. Thanks! FEDORA-EPEL-2020-42a5acb0dc has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-42a5acb0dc FEDORA-EPEL-2020-42a5acb0dc has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-42a5acb0dc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. Created attachment 1712586 [details]
colordiff 1.0.19 on CentOS 7
1.0.19 seems to work OK on CentOS 7 - see attached screenshot
Awesome. I switched to the EPEL dev and downloaded it already. I have not had any issues. Thank you so much for your help. FEDORA-EPEL-2020-42a5acb0dc has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. |