Bug 186887
Summary: | Review Request: libnetfilter_conntrack - Netfilter conntrack userspace library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul P Komkoff Jr <i> |
Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | gwync:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-05-14 16:48:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 186811 | ||
Bug Blocks: | 163779, 186892 |
Description
Paul P Komkoff Jr
2006-03-27 08:59:45 UTC
http://stingr.net/l/fe/libnetfilter_conntrack.spec http://stingr.net/l/fe/libnetfilter_conntrack-0.0.30-2.src.rpm Since 186811 has been approved now, any objections to this package? In answer to comment #2: Each package must go through a review. ;) And here is one for this package: See below - Rpmlint output. OK - Package name. OK - Spec file name matches. OK - Package guidelines. OK - Licsense. OK - License field matches in spec. OK - License included in files OK - Spec in american english OK - Spec legible OK - Md5sum of source from upstream e07f3d159a869900fbf23f5df12aaf3e libnetfilter_conntrack-0.0.30.tar.bz2 e07f3d159a869900fbf23f5df12aaf3e libnetfilter_conntrack-0.0.30.tar.bz2.1 OK - Compiles and builds on one arch at least. (builds in mock on fc5) OK - Excludearch not needed OK - Forbidden buildrequires not included OK - All required buildrequires included OK - Ldconfig in post/postun if including libs. OK - Owns all directories it creates. OK - No duplicate files in %files listing. OK - Permissions on files correct. OK - Clean section correct. OK - Macros consistant. OK - Code not content. OK - Docs must not affect runtime. OK - Header files/libs in a devel package. OK - .so files in devel package. OK - Devel package requires base package. OK - No .la files. OK - Doesn't own any files/dirs that are already owned by others. 1. One rpmlint warning: W: libnetfilter_conntrack-devel summary-not-capitalized netfilter conntrack userspace library Suggest: Change the devel summary to "Netfilter conntrack userspace library development files" Looks good. If you could fix up the rpmlint warning when you import into CVS that would be great. This package is APPROVED. Don't forget to close this bug when you have imported and built the package. Package Change Request ====================== Package Name: libnetfilter_conntrack New Branches: EL-4 EL-5 Owners: stingray jrussek jrussek doesn't seem to be in the packager group. Can you get their sponsorship fixed up, or file a new request? Package Change Request ====================== Package Name: libnetfilter_conntrack New Branches: EL-5 EL-6 Owners: stingray Git done (by process-git-requests). |