Bug 1869433 (php-opis-closure)

Summary: Review Request: php-opis-closure - A library that can be used to serialize closures and arbitrary objects
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-31 15:49:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1821537, 1865217    
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2020-08-18 01:33:25 UTC
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/master/php-opis-closure/php-opis-closure.spec

SRPM URL: https://fedorapeople.org/~siwinski/SRPMS/php-opis-closure-3.5.6-1.fc32.src.rpm

Description:
Opis Closure is a library that aims to overcome PHP's limitations regarding
closure serialization by providing a wrapper that will make all closures
serializable.

Fedora Account System Username: siwinski

Comment 1 Remi Collet 2020-08-21 13:30:52 UTC
Created attachment 1712175 [details]
phpci.log

Comment 2 Remi Collet 2020-08-21 13:31:10 UTC
Created attachment 1712176 [details]
review.txt

Comment 3 Remi Collet 2020-08-21 13:33:07 UTC
Notice: don't try to run test with "php70" when phpunit7 is used

-for PHP_EXEC in "" %{?rhel:php55 php56} php70 php71 php72 php73 php74; do
+for PHP_EXEC in "" %{?rhel:php55 php56 php70} php71 php72 php73 php74; do

Else error is raised : "This version of PHPUnit is supported on PHP 7.1, PHP 7.2, and PHP 7.3."


[x]: Package complies to the Packaging Guidelines


** APPROVED **

Comment 4 Shawn Iwinski 2020-08-21 17:43:40 UTC
Thanks Remi!

I'll make the test change after initial import.

Comment 6 Gwyn Ciesla 2020-08-21 19:01:17 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-opis-closure

Comment 7 Fedora Update System 2020-08-23 00:54:23 UTC
FEDORA-2020-644d4cf4e7 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-644d4cf4e7

Comment 8 Fedora Update System 2020-08-23 00:55:08 UTC
FEDORA-EPEL-2020-b006932aa7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-b006932aa7

Comment 9 Fedora Update System 2020-08-24 01:19:21 UTC
FEDORA-EPEL-2020-b006932aa7 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-b006932aa7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-08-24 01:47:17 UTC
FEDORA-2020-644d4cf4e7 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-644d4cf4e7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-644d4cf4e7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-08-31 15:49:20 UTC
FEDORA-2020-644d4cf4e7 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2020-09-07 16:31:34 UTC
FEDORA-EPEL-2020-b006932aa7 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.