Bug 1870111

Summary: No warning that setting 'techPreviewUserWorkload' setting in the monitoring configmap is deprecated
Product: OpenShift Container Platform Reporter: Simon Pasquier <spasquie>
Component: MonitoringAssignee: Simon Pasquier <spasquie>
Status: CLOSED ERRATA QA Contact: Junqi Zhao <juzhao>
Severity: low Docs Contact:
Priority: medium    
Version: 4.6CC: alegrand, anpicker, erooth, kakkoyun, lcosic, mloibl, pkrupa, surbania
Target Milestone: ---Keywords: UpcomingSprint
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 16:29:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Simon Pasquier 2020-08-19 11:32:49 UTC
Description of problem:
There's nothing warning the user that setting 'techPreviewUserWorkload' is deprecated and is superseded by the 'enableUserWorkload' key.

Version-Release number of selected component (if applicable):
4.6

How reproducible:
Always

Steps to Reproduce:
1. Enable user workload monitoring with
apiVersion: v1
kind: ConfigMap
metadata:
  name: cluster-monitoring-config
  namespace: openshift-monitoring
data:
  config.yaml: |-
    techPreviewUserWorkload: {enabled: true}

Actual results:
No indication that the setting is deprecated.

Expected results:
At least a warning in the logs.

Additional info:
When user workload monitoring is enabled via 'techPreviewUserWorkload', the settings from the openshift-user-workload-monitoring/user-workload-monitoring-config configmap are discarded.

Comment 5 Junqi Zhao 2020-08-24 01:36:05 UTC
tested with 4.6.0-0.nightly-2020-08-23-185640, issue is fixed
# oc -n openshift-monitoring logs $(oc -n openshift-monitoring get po | grep cluster-monitoring-operator | awk '{print $1}') -c cluster-monitoring-operator | grep techPreviewUserWorkload -C3
I0824 01:28:54.478207       1 tasks.go:46] ran task 5 of 15: Updating Prometheus-k8s
I0824 01:28:54.478321       1 operator.go:373] Updating ClusterOperator status to done.
I0824 01:31:38.820843       1 operator.go:269] Triggering an update due to ConfigMap or Secret: openshift-monitoring/cluster-monitoring-config
W0824 01:31:38.821643       1 operator.go:452] User Workload Monitoring enabled via the deprecated 'techPreviewUserWorkload' setting in "openshift-monitoring/cluster-monitoring-config" configmap. Use the 'enableUserWorkload' setting instead.
I0824 01:31:38.840182       1 operator.go:356] Updating ClusterOperator status to in progress.
I0824 01:31:38.848290       1 tasks.go:44] running task 15 of 15: Updating User Workload Thanos Ruler
I0824 01:31:38.850736       1 tasks.go:44] running task 1 of 15: Updating Prometheus Operator

Comment 7 errata-xmlrpc 2020-10-27 16:29:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196