Bug 1870488
| Summary: | [incremental_backup] After restart libvirtd, pull mode backup with tls enabled causing qemu crashed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux Advanced Virtualization | Reporter: | yisun | ||||||
| Component: | libvirt | Assignee: | Peter Krempa <pkrempa> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | yisun | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 8.3 | CC: | dyuan, jdenemar, lmen, meili, pkrempa, virt-maint, xuzhang | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | 8.3 | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | libvirt-6.6.0-6.el8 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2020-11-17 17:50:55 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
yisun
2020-08-20 08:44:32 UTC
Created attachment 1711978 [details]
gdb-qemu-kvm-vm1.txt
Created attachment 1711979 [details]
libvirtd-debug.log
This is a qemu crash, but involved a libvirtd restart, so set component to 'libvirt' for now. If it's a qemu issue after debug, pls help to move to qemu team, thx The qemu proces abort()s because libvirt didn't delete the TLS_x509 and secret objects when aborting the backup job after restart of libvirtd as their aliases were not written out to the status XML. Note that upstream qemu now reports an error rather than abort()-ing. Fixed upstream:
commit 1a5f35dbd2c4d83f7629579bcd8b23929a492b29
Author: Peter Krempa <pkrempa>
Date: Mon Sep 14 17:59:07 2020 +0200
qemu: backup: Write TLS cert and secret object aliases into status XML
We've put the aliases into the backup job definition after the status
XML was already written so they didn't appear in the on-disk state.
Move the code putting them into the private definition earlier, so that
the status XML update done by saving blockjobs already writes them out.
Also add a note notifying that the block job status update writes the
status XML.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1870488
Fixes: 423576679a5
Signed-off-by: Peter Krempa <pkrempa>
Reviewed-by: Michal Privoznik <mprivozn>
Reviewed-by: Ján Tomko <jtomko>
commit 5058062b5daa6d841154eda7f6a53c39d64e765e
Author: Peter Krempa <pkrempa>
Date: Mon Sep 14 17:58:09 2020 +0200
qemu: backup: Remove note that TLS should be implemented
Commit 423576679a5 implementing TLS forgot to remove the comment.
Signed-off-by: Peter Krempa <pkrempa>
Reviewed-by: Michal Privoznik <mprivozn>
Reviewed-by: Ján Tomko <jtomko>
commit 6c2d91118dc99426a79bf48c8d795e243c522dbd
Author: Peter Krempa <pkrempa>
Date: Mon Sep 14 17:46:42 2020 +0200
qemustatusxml2xml: backup-pull: Test private data formatting/parsing
Modify the test case to enable TLS and add private data containing
aliases of objects corresponding to a TLS setup.
Signed-off-by: Peter Krempa <pkrempa>
Reviewed-by: Michal Privoznik <mprivozn>
Reviewed-by: Ján Tomko <jtomko>
Verified with: libvirt-6.6.0-6.module+el8.3.0+8125+aefcf088.x86_64 Result: PASS [root@dell-per740xd-10 ~]# cat backup_full.xml <domainbackup mode="pull"> <server name="dell-per740xd-10.lab.eng.pek2.redhat.com" port="10809" tls="yes"/> <disks> <disk backup="no" name="vda" /> <disk backup="yes" name="vdb" type="file"> <scratch file="/tmp/scratch_file_0" /> </disk> </disks> </domainbackup> [root@dell-per740xd-10 ~]# virsh backup-begin vm1 backup_full.xml Backup started [root@dell-per740xd-10 ~]# systemctl restart libvirtd [root@dell-per740xd-10 ~]# virsh domjobinfo vm1 Job type: Unbounded Operation: Backup Time elapsed: 7529 ms Temporary disk space use: 0.000 B Temporary disk space total: 5.000 GiB [root@dell-per740xd-10 ~]# virsh domjobabort vm1 [root@dell-per740xd-10 ~]# virsh list Id Name State ---------------------- ... 5 vm1 running [root@dell-per740xd-10 ~]# virsh backup-begin vm1 backup_full.xml Backup started [root@dell-per740xd-10 ~]# virsh domjobinfo vm1 Job type: Unbounded Operation: Backup Time elapsed: 16057 ms Temporary disk space use: 0.000 B Temporary disk space total: 5.000 GiB [root@dell-per740xd-10 ~]# virsh domjobabort vm1 [root@dell-per740xd-10 ~]# virsh list Id Name State ---------------------- ... 5 vm1 running Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (virt:8.3 bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:5137 |