Bug 1870567

Description of problem:
When locate of system is set to e.g. en_EN.UTF-8, then D-Bus method GetStatus provided by rhsm.service returns status in English language and locale string used in GetStatus method is ignored

Version-Release number of selected component (if applicable):
[root@rhel82 ~]# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: 3.1.16-1
subscription management rules: 5.40
subscription-manager: 1.26.17-1.el8_2

How reproducible:
100%

Steps to Reproduce:
1. Ensure that English language is used as system locale

[root@rhel82 ~]# localectl 
   System Locale: LANG=en_US.UTF-8
       VC Keymap: us
      X11 Layout: us


2. Make sure that rhsm.service is running

[root@rhel82 ~]# systemctl restart rhsm.service 
[root@rhel82 ~]# systemctl status rhsm.service 
● rhsm.service - RHSM dbus service
   Loaded: loaded (/usr/lib/systemd/system/rhsm.service; disabled; vendor preset: disabled)
   Active: active (running) since Thu 2020-08-20 13:05:34 CEST; 3s ago
 Main PID: 42272 (rhsm-service)
    Tasks: 2 (limit: 11339)
   Memory: 28.7M
   CGroup: /system.slice/rhsm.service
           └─42272 /usr/libexec/platform-python /usr/libexec/rhsm-service

Aug 20 13:05:34 rhel82 rhsm-service[42272]: DEBUG [rhsm.https:56] Using standard libs to provide httplib and ssl
Aug 20 13:05:34 rhel82 rhsm-service[42272]: DEBUG [rhsmlib.dbus.service_wrapper:66] Starting DBus service with name com.redhat.RHSM1
Aug 20 13:05:34 rhel82 rhsm-service[42272]: DEBUG [subscription_manager.identity:139] Loading consumer info from identity certificates.
Aug 20 13:05:34 rhel82 systemd[1]: Started RHSM dbus service.
Aug 20 13:05:34 rhel82 rhsm-service[42272]: DEBUG [rhsmlib.dbus.server:182] Start notification sent
Aug 20 13:05:34 rhel82 rhsm-service[42272]: DEBUG [rhsmlib.file_monitor:201] Added i-notifier watcher for: /etc/pki/consumer with mask: 642
Aug 20 13:05:34 rhel82 rhsm-service[42272]: DEBUG [rhsmlib.file_monitor:201] Added i-notifier watcher for: /etc/pki/entitlement with mask: 642
Aug 20 13:05:34 rhel82 rhsm-service[42272]: DEBUG [rhsmlib.file_monitor:201] Added i-notifier watcher for: /etc/rhsm/rhsm.conf with mask: 642
Aug 20 13:05:34 rhel82 rhsm-service[42272]: DEBUG [rhsmlib.file_monitor:201] Added i-notifier watcher for: /etc/pki/product with mask: 642
Aug 20 13:05:34 rhel82 rhsm-service[42272]: DEBUG [rhsmlib.file_monitor:201] Added i-notifier watcher for: /etc/rhsm/syspurpose/syspurpose.json with mask: 642


3. Try to get system status using D-Bus method GetStatus using several different locales:

[root@rhel82 ~]# busctl call com.redhat.RHSM1 /com/redhat/RHSM1/Entitlement com.redhat.RHSM1.Entitlement GetStatus ss "" "es_ES.UTF-8"
s "{\"status\": \"Current\", \"reasons\": {}, \"valid\": true}"  <===== status is "Current" (string with English locale is returned)

[root@rhel82 ~]# busctl call com.redhat.RHSM1 /com/redhat/RHSM1/Entitlement com.redhat.RHSM1.Entitlement GetStatus ss "" "fr_FR.UTF-8"
s "{\"status\": \"Current\", \"reasons\": {}, \"valid\": true}"  <===== status is "Current" (string with English locale is returned)


4. Try to get status using subscription-manager using and different LANG environment variables

[root@rhel82 ~]# LANG="es_ES.UTF-8" subscription-manager status
You are attempting to use a locale that is not installed.
+-------------------------------------------+
   Información de estatus del sistema
+-------------------------------------------+
Overall Status: Actual  <===== Status is translated to Spanish

System Purpose Status: Not Specified

[root@rhel82 ~]# LANG="fr_FR.UTF-8" subscription-manager status
You are attempting to use a locale that is not installed.
+-------------------------------------------+
   Détails du statut du système
+-------------------------------------------+
Overall Status: Actuel  <===== Status is translated to French

System Purpose Status: Not Specified



Actual results:
GetStatus returns status with locale that is specified for the system.

Expected results:
GetStatus should return status with locale specified in D-Bus method call

Additional info:

It also seems that some localized messages are saved in our cache files. This case was tested on Fedora, but I believe that we can observer similar behavior on RHEL8.2

1. Remove all pools:
[root@thinkpad-t580 ~]# subscription-manager remove --all


2. Delete cache file:
[root@thinkpad-t580 ~]# rm -f /var/lib/rhsm/cache/entitlement_status.json


3. Restart rhsm service:
[root@thinkpad-t580 ~]# systemctl restart rhsm.service


4. Try to get status using Spanish locale:
[root@thinkpad-t580 subscription-manager]# busctl call com.redhat.RHSM1 /com/redhat/RHSM1/Entitlement com.redhat.RHSM1.Entitlement GetStatus ss "" "es_ES.UTF-8"
s "{\"status\": \"Invalid\", \"reasons\": {\"SP Server Bits\": [\"No est\\u00e1 soportado por una suscripci\\u00f3n v\\u00e1lida\"], \"Fake OS Bits\": [\"No est\\u00e1 soportado por una suscripci\\u00f3n v\\u00e1lida\"]}, \"valid\": false}"

^
Reasons are in Spanish locale

4. Try to get status using French locale:
[root@thinkpad-t580 subscription-manager]# busctl call com.redhat.RHSM1 /com/redhat/RHSM1/Entitlement com.redhat.RHSM1.Entitlement GetStatus ss "" "fr_FR.UTF-8"
s "{\"status\": \"Invalid\", \"reasons\": {\"SP Server Bits\": [\"No est\\u00e1 soportado por una suscripci\\u00f3n v\\u00e1lida\"], \"Fake OS Bits\": [\"No est\\u00e1 soportado por una suscripci\\u00f3n v\\u00e1lida\"]}, \"valid\": false}"

^
Reasons are in still in Spanish locale


5. You can see that entitlement status is cached and it contains Spanish strings:
[root@thinkpad-t580 subscription-manager]# cat /var/lib/rhsm/cache/entitlement_status.json | python -m json.tool
{
    "status": "invalid",
    "compliant": false,
    "date": "2020-08-20T11:35:46+0000",
    "compliantUntil": null,
    "compliantProducts": {},
    "nonCompliantProducts": [
        "99000",
        "38072"
    ],
    "partiallyCompliantProducts": {},
    "partialStacks": {},
    "productComplianceDateRanges": {},
    "reasons": [
        {
            "key": "NOTCOVERED",
            "message": "No est\u00e1 soportado por una suscripci\u00f3n v\u00e1lida",
            "attributes": {
                "name": "SP Server Bits",
                "product_id": "99000"
            }
        },
        {
            "key": "NOTCOVERED",
            "message": "No est\u00e1 soportado por una suscripci\u00f3n v\u00e1lida",
            "attributes": {
                "name": "Fake OS Bits",
                "product_id": "38072"
            }
        }
    ]
}