Bug 1871697
| Summary: | Review Request: dhall - A configuration language guaranteed to terminate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | Package Review | Assignee: | Robert-AndrĂ© Mauchin đ§ <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | dhall-1.32.0-2.fc34 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-09-25 16:42:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1871452, 1871643, 1871644, 1871648, 1873973 | ||
| Bug Blocks: | |||
|
Description
Jens Petersen
2020-08-24 04:40:06 UTC
- Bump to 1.34.0
- Build fails:
Building library for dhall-1.32.0..
[ 1 of 42] Compiling Dhall.Context ( src/Dhall/Context.hs, dist/build/Dhall/Context.o )
[ 2 of 42] Compiling Dhall.Crypto ( ghc-src/Dhall/Crypto.hs, dist/build/Dhall/Crypto.o )
[ 3 of 42] Compiling Dhall.Import.Manager ( ghc-src/Dhall/Import/Manager.hs, dist/build/Dhall/Import/Manager.o )
[ 4 of 42] Compiling Dhall.Map ( src/Dhall/Map.hs, dist/build/Dhall/Map.o )
[ 5 of 42] Compiling Dhall.Optics ( src/Dhall/Optics.hs, dist/build/Dhall/Optics.o )
[ 6 of 42] Compiling Dhall.Set ( src/Dhall/Set.hs, dist/build/Dhall/Set.o )
[ 7 of 42] Compiling Dhall.Syntax[boot] ( src/Dhall/Syntax.hs-boot, dist/build/Dhall/Syntax.o-boot )
[ 8 of 42] Compiling Dhall.Pretty.Internal[boot] ( src/Dhall/Pretty/Internal.hs-boot, dist/build/Dhall/Pretty/Internal.o-boot )
[ 9 of 42] Compiling Dhall.Util[boot] ( src/Dhall/Util.hs-boot, dist/build/Dhall/Util.o-boot )
[10 of 42] Compiling Dhall.Src ( src/Dhall/Src.hs, dist/build/Dhall/Src.o )
src/Dhall/Src.hs:17:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
17 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[11 of 42] Compiling Dhall.Syntax ( src/Dhall/Syntax.hs, dist/build/Dhall/Syntax.o )
[12 of 42] Compiling Dhall.URL ( src/Dhall/URL.hs, dist/build/Dhall/URL.o )
src/Dhall/URL.hs:6:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
6 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[13 of 42] Compiling Dhall.Eval ( src/Dhall/Eval.hs, dist/build/Dhall/Eval.o )
src/Dhall/Eval.hs:56:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
56 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[14 of 42] Compiling Dhall.Normalize ( src/Dhall/Normalize.hs, dist/build/Dhall/Normalize.o )
src/Dhall/Normalize.hs:24:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
24 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[15 of 42] Compiling Dhall.Substitution ( src/Dhall/Substitution.hs, dist/build/Dhall/Substitution.o )
[16 of 42] Compiling Dhall.Binary ( src/Dhall/Binary.hs, dist/build/Dhall/Binary.o )
src/Dhall/Binary.hs:54:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
54 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[17 of 42] Compiling Dhall.Pretty.Internal ( src/Dhall/Pretty/Internal.hs, dist/build/Dhall/Pretty/Internal.o )
src/Dhall/Pretty/Internal.hs:68:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
68 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[18 of 42] Compiling Dhall.Pretty ( src/Dhall/Pretty.hs, dist/build/Dhall/Pretty.o )
[19 of 42] Compiling Dhall.Diff ( src/Dhall/Diff.hs, dist/build/Dhall/Diff.o )
src/Dhall/Diff.hs:21:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
21 | import Data.Monoid (Any(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[20 of 42] Compiling Dhall.Parser.Combinators ( src/Dhall/Parser/Combinators.hs, dist/build/Dhall/Parser/Combinators.o )
[21 of 42] Compiling Dhall.Parser.Token ( src/Dhall/Parser/Token.hs, dist/build/Dhall/Parser/Token.o )
src/Dhall/Parser/Token.hs:116:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
116 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[22 of 42] Compiling Dhall.Parser.Expression ( src/Dhall/Parser/Expression.hs, dist/build/Dhall/Parser/Expression.o )
src/Dhall/Parser/Expression.hs:15:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
15 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[23 of 42] Compiling Dhall.Core ( src/Dhall/Core.hs, dist/build/Dhall/Core.o )
[24 of 42] Compiling Dhall.Parser ( src/Dhall/Parser.hs, dist/build/Dhall/Parser.o )
src/Dhall/Parser.hs:24:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
24 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[25 of 42] Compiling Dhall.Lint ( src/Dhall/Lint.hs, dist/build/Dhall/Lint.o )
[26 of 42] Compiling Dhall.Import.Types ( src/Dhall/Import/Types.hs, dist/build/Dhall/Import/Types.o )
src/Dhall/Import/Types.hs:14:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
14 | import Data.Semigroup ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[27 of 42] Compiling Dhall.Util ( src/Dhall/Util.hs, dist/build/Dhall/Util.o )
src/Dhall/Util.hs:25:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
25 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[28 of 42] Compiling Dhall.TypeCheck ( src/Dhall/TypeCheck.hs, dist/build/Dhall/TypeCheck.o )
src/Dhall/TypeCheck.hs:36:1: warning: [-Wunused-imports]
The import of âSemigroupâ from module âData.Semigroupâ is redundant
|
36 | import Data.Semigroup (Max(..), Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[29 of 42] Compiling Dhall.Tags ( src/Dhall/Tags.hs, dist/build/Dhall/Tags.o )
src/Dhall/Tags.hs:13:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
13 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[30 of 42] Compiling Dhall.Import.HTTP ( ghc-src/Dhall/Import/HTTP.hs, dist/build/Dhall/Import/HTTP.o )
ghc-src/Dhall/Import/HTTP.hs:15:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
15 | import Data.Semigroup ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[31 of 42] Compiling Dhall.Import ( src/Dhall/Import.hs, dist/build/Dhall/Import.o )
src/Dhall/Import.hs:151:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
151 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[32 of 42] Compiling Dhall.Freeze ( src/Dhall/Freeze.hs, dist/build/Dhall/Freeze.o )
src/Dhall/Freeze.hs:20:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
20 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[33 of 42] Compiling Dhall.Format ( src/Dhall/Format.hs, dist/build/Dhall/Format.o )
src/Dhall/Format.hs:13:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
13 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[34 of 42] Compiling Dhall.DirectoryTree ( src/Dhall/DirectoryTree.hs, dist/build/Dhall/DirectoryTree.o )
src/Dhall/DirectoryTree.hs:14:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
14 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[35 of 42] Compiling Dhall ( src/Dhall.hs, dist/build/Dhall.o )
src/Dhall.hs:141:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
141 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[36 of 42] Compiling Dhall.Tutorial ( src/Dhall/Tutorial.hs, dist/build/Dhall/Tutorial.o )
[37 of 42] Compiling Dhall.TH ( src/Dhall/TH.hs, dist/build/Dhall/TH.o )
src/Dhall/TH.hs:17:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
17 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[38 of 42] Compiling Dhall.Deriving ( src/Dhall/Deriving.hs, dist/build/Dhall/Deriving.o )
[39 of 42] Compiling Paths_dhall ( dist/build/autogen/Paths_dhall.hs, dist/build/Paths_dhall.o )
[40 of 42] Compiling Dhall.Version ( src/Dhall/Version.hs, dist/build/Dhall/Version.o )
[41 of 42] Compiling Dhall.Repl ( src/Dhall/Repl.hs, dist/build/Dhall/Repl.o )
src/Dhall/Repl.hs:16:1: warning: [-Wunused-imports]
The import of âControl.Monad.Failâ is redundant
except perhaps to import instances from âControl.Monad.Failâ
To import instances alone, use: import Control.Monad.Fail()
|
16 | import Control.Monad.Fail ( MonadFail )
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/Dhall/Repl.hs:24:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
24 | import Data.Semigroup ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[42 of 42] Compiling Dhall.Main ( src/Dhall/Main.hs, dist/build/Dhall/Main.o )
src/Dhall/Main.hs:28:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
28 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[ 1 of 42] Compiling Dhall.Context ( src/Dhall/Context.hs, dist/build/Dhall/Context.p_o )
[ 2 of 42] Compiling Dhall.Crypto ( ghc-src/Dhall/Crypto.hs, dist/build/Dhall/Crypto.p_o )
[ 3 of 42] Compiling Dhall.Import.Manager ( ghc-src/Dhall/Import/Manager.hs, dist/build/Dhall/Import/Manager.p_o )
[ 4 of 42] Compiling Dhall.Map ( src/Dhall/Map.hs, dist/build/Dhall/Map.p_o )
[ 5 of 42] Compiling Dhall.Optics ( src/Dhall/Optics.hs, dist/build/Dhall/Optics.p_o )
[ 6 of 42] Compiling Dhall.Set ( src/Dhall/Set.hs, dist/build/Dhall/Set.p_o )
[ 7 of 42] Compiling Dhall.Syntax[boot] ( src/Dhall/Syntax.hs-boot, dist/build/Dhall/Syntax.p_o-boot )
[ 8 of 42] Compiling Dhall.Pretty.Internal[boot] ( src/Dhall/Pretty/Internal.hs-boot, dist/build/Dhall/Pretty/Internal.p_o-boot )
[ 9 of 42] Compiling Dhall.Util[boot] ( src/Dhall/Util.hs-boot, dist/build/Dhall/Util.p_o-boot )
[10 of 42] Compiling Dhall.Src ( src/Dhall/Src.hs, dist/build/Dhall/Src.p_o )
src/Dhall/Src.hs:17:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
17 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[11 of 42] Compiling Dhall.Syntax ( src/Dhall/Syntax.hs, dist/build/Dhall/Syntax.p_o )
[12 of 42] Compiling Dhall.URL ( src/Dhall/URL.hs, dist/build/Dhall/URL.p_o )
src/Dhall/URL.hs:6:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
6 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[13 of 42] Compiling Dhall.Eval ( src/Dhall/Eval.hs, dist/build/Dhall/Eval.p_o )
src/Dhall/Eval.hs:56:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
56 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[14 of 42] Compiling Dhall.Normalize ( src/Dhall/Normalize.hs, dist/build/Dhall/Normalize.p_o )
src/Dhall/Normalize.hs:24:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
24 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[15 of 42] Compiling Dhall.Substitution ( src/Dhall/Substitution.hs, dist/build/Dhall/Substitution.p_o )
[16 of 42] Compiling Dhall.Binary ( src/Dhall/Binary.hs, dist/build/Dhall/Binary.p_o )
src/Dhall/Binary.hs:54:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
54 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[17 of 42] Compiling Dhall.Pretty.Internal ( src/Dhall/Pretty/Internal.hs, dist/build/Dhall/Pretty/Internal.p_o )
src/Dhall/Pretty/Internal.hs:68:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
68 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[18 of 42] Compiling Dhall.Pretty ( src/Dhall/Pretty.hs, dist/build/Dhall/Pretty.p_o )
[19 of 42] Compiling Dhall.Diff ( src/Dhall/Diff.hs, dist/build/Dhall/Diff.p_o )
src/Dhall/Diff.hs:21:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
21 | import Data.Monoid (Any(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[20 of 42] Compiling Dhall.Parser.Combinators ( src/Dhall/Parser/Combinators.hs, dist/build/Dhall/Parser/Combinators.p_o )
[21 of 42] Compiling Dhall.Parser.Token ( src/Dhall/Parser/Token.hs, dist/build/Dhall/Parser/Token.p_o )
src/Dhall/Parser/Token.hs:116:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
116 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[22 of 42] Compiling Dhall.Parser.Expression ( src/Dhall/Parser/Expression.hs, dist/build/Dhall/Parser/Expression.p_o )
src/Dhall/Parser/Expression.hs:15:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
15 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[23 of 42] Compiling Dhall.Core ( src/Dhall/Core.hs, dist/build/Dhall/Core.p_o )
[24 of 42] Compiling Dhall.Parser ( src/Dhall/Parser.hs, dist/build/Dhall/Parser.p_o )
src/Dhall/Parser.hs:24:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
24 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[25 of 42] Compiling Dhall.Lint ( src/Dhall/Lint.hs, dist/build/Dhall/Lint.p_o )
[26 of 42] Compiling Dhall.Import.Types ( src/Dhall/Import/Types.hs, dist/build/Dhall/Import/Types.p_o )
src/Dhall/Import/Types.hs:14:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
14 | import Data.Semigroup ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[27 of 42] Compiling Dhall.Util ( src/Dhall/Util.hs, dist/build/Dhall/Util.p_o )
src/Dhall/Util.hs:25:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
25 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[28 of 42] Compiling Dhall.TypeCheck ( src/Dhall/TypeCheck.hs, dist/build/Dhall/TypeCheck.p_o )
src/Dhall/TypeCheck.hs:36:1: warning: [-Wunused-imports]
The import of âSemigroupâ from module âData.Semigroupâ is redundant
|
36 | import Data.Semigroup (Max(..), Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[29 of 42] Compiling Dhall.Tags ( src/Dhall/Tags.hs, dist/build/Dhall/Tags.p_o )
src/Dhall/Tags.hs:13:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
13 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[30 of 42] Compiling Dhall.Import.HTTP ( ghc-src/Dhall/Import/HTTP.hs, dist/build/Dhall/Import/HTTP.p_o )
ghc-src/Dhall/Import/HTTP.hs:15:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
15 | import Data.Semigroup ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[31 of 42] Compiling Dhall.Import ( src/Dhall/Import.hs, dist/build/Dhall/Import.p_o )
src/Dhall/Import.hs:151:1: warning: [-Wunused-imports]
The import of âData.Semigroupâ is redundant
except perhaps to import instances from âData.Semigroupâ
To import instances alone, use: import Data.Semigroup()
|
151 | import Data.Semigroup (Semigroup(..))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[32 of 42] Compiling Dhall.Freeze ( src/Dhall/Freeze.hs, dist/build/Dhall/Freeze.p_o )
src/Dhall/Freeze.hs:20:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
20 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[33 of 42] Compiling Dhall.Format ( src/Dhall/Format.hs, dist/build/Dhall/Format.p_o )
src/Dhall/Format.hs:13:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
13 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[34 of 42] Compiling Dhall.DirectoryTree ( src/Dhall/DirectoryTree.hs, dist/build/Dhall/DirectoryTree.p_o )
src/Dhall/DirectoryTree.hs:14:1: warning: [-Wunused-imports]
The import of âData.Monoidâ is redundant
except perhaps to import instances from âData.Monoidâ
To import instances alone, use: import Data.Monoid()
|
14 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^
[35 of 42] Compiling Dhall ( src/Dhall.hs, dist/build/Dhall.p_o )
/usr/lib64/ghc-8.8.4/contravariant-1.5.2/Data/Functor/Contravariant/Divisible.p_hi
Declaration for $fDivisibleSettableStateVar:
Failed to load interface for âData.StateVarâ
Perhaps you haven't installed the profiling libraries for package âStateVar-1.2â?
Use -v (or `:set -v` in ghci) to see a list of the files searched for.
Cannot continue after interface file error
Thank you so much for the reviews, Robert-AndrĂ© đ§ It will be awesome to get dhall into Fedora. I will look into the failure here once those deps are built. đ (In reply to Robert-AndrĂ© Mauchin đ§ from comment #1) > [35 of 42] Compiling Dhall ( src/Dhall.hs, dist/build/Dhall.p_o ) > /usr/lib64/ghc-8.8.4/contravariant-1.5.2/Data/Functor/Contravariant/ > Divisible.p_hi > Declaration for $fDivisibleSettableStateVar: > Failed to load interface for âData.StateVarâ > Perhaps you haven't installed the profiling libraries for package > âStateVar-1.2â? > Use -v (or `:set -v` in ghci) to see a list of the files searched for. > Cannot continue after interface file error Sadly turns out this is caused by packaging/change of behavior of ghc-pkg-8.8. đą In this case for example ghc-contravariant-devel pulls in ghc-StateVar-devel, _but_ ghc-contravariant-prof is missing the corresponding requires for ghc-StateVar-prof. Pretty bad news. :-( Thanks for being the first to catch this! I will have to take some action. So it turned out fortunately not to be such a broad bug as originally I had feared: a corner case where the current ghc-StateVar build's hash key contains the substring "rts" which I was filtering out too simplistically. > Sadly turns out this is caused by packaging/change of behavior of ghc-pkg-8.8. So please ignore this incorrect sentence ^ in the previous comment. I opened bug 1873687 against ghc-rpm-macros anyway. NEEDINFO me when it's fixed and ready. Oops, that needinfo was premature, except bug 1873973 now blocks building dhall on i686 (since Agda disables prof libraries on i686). Package approved.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License". 2820 files have unknown license. Detailed output of licensecheck
in /home/bob/packaging/review/dhall/review-dhall/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: ghc-dhall-devel.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-
dhall
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: dhall-1.32.0-1.fc34.x86_64.rpm
ghc-dhall-1.32.0-1.fc34.x86_64.rpm
ghc-dhall-devel-1.32.0-1.fc34.x86_64.rpm
dhall-1.32.0-1.fc34.src.rpm
dhall.x86_64: W: spelling-error %description -l en_US evaluator -> evaluate, elevator
dhall.x86_64: W: no-documentation
dhall.x86_64: W: no-manual-page-for-binary dhall
ghc-dhall.x86_64: W: no-documentation
ghc-dhall-devel.x86_64: W: no-documentation
dhall.src: W: spelling-error %description -l en_US evaluator -> evaluate, elevator
4 packages and 0 specfiles checked; 0 errors, 6 warnings.
Thank you for the review https://pagure.io/releng/fedora-scm-requests/issue/28156 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dhall FEDORA-2020-ce7cc4dfc4 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ce7cc4dfc4 FEDORA-2020-ce7cc4dfc4 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-ce7cc4dfc4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ce7cc4dfc4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-ce7cc4dfc4 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ce7cc4dfc4 FEDORA-2020-ce7cc4dfc4 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-ce7cc4dfc4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ce7cc4dfc4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-99da0c3c33 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-99da0c3c33 FEDORA-2020-99da0c3c33 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-99da0c3c33 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-99da0c3c33 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-ce7cc4dfc4 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-99da0c3c33 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. |