Bug 1871944

Summary: [sig-apps][Feature:DeploymentConfig] deploymentconfigs with revision history limits should never persist more old deployments than acceptable after being observed by the controller
Product: OpenShift Container Platform Reporter: Antonio Ojea <aojeagar>
Component: openshift-controller-managerAssignee: Tomáš Nožička <tnozicka>
Status: CLOSED ERRATA QA Contact: zhou ying <yinzhou>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.6CC: aos-bugs, knarra, maszulik, mfojtik, xxia
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: workloads
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
[sig-apps][Feature:DeploymentConfig] deploymentconfigs with revision history limits should never persist more old deployments than acceptable after being observed by the controller
Last Closed: 2020-10-27 16:31:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Antonio Ojea 2020-08-24 16:24:23 UTC 
test:
[sig-apps][Feature:DeploymentConfig] deploymentconfigs with revision history limits should never persist more old deployments than acceptable after being observed by the controller 

is failing frequently in CI, see search results:
https://search.ci.openshift.org/?maxAge=168h&context=1&type=bug%2Bjunit&name=&maxMatches=5&maxBytes=20971520&groupBy=job&search=%5C%5Bsig-apps%5C%5D%5C%5BFeature%3ADeploymentConfig%5C%5D+deploymentconfigs+with+revision+history+limits+should+never+persist+more+old+deployments+than+acceptable+after+being+observed+by+the+controller


I checked several jobs and it is mostly flaky, failing the first try and succeeding in the second one
Comment 1 Maciej Szulik 2020-09-11 13:25:39 UTC 
With https://github.com/openshift/origin/pull/25010 this should be fixed, moving to qa.
Comment 3 zhou ying 2020-09-15 02:40:18 UTC 
We still could see the reproduce here (All those runs are failed on 2020-09-15's run) 

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/785/pull-ci-openshift-cluster-network-operator-master-e2e-ovn-hybrid-step-registry/1304878899443798016

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25503/pull-ci-openshift-origin-master-e2e-aws-fips/1305672355506294784

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ocp-4.6-e2e-vsphere/1304939164050919424

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/786/pull-ci-openshift-cluster-network-operator-master-e2e-ovn-step-registry/1305634427375718400




All are failing the first try and succeeding in the second one.
Comment 4 Maciej Szulik 2020-09-15 10:31:04 UTC 
Well this is interesting, it looks like the unterminatedPods array has 2 identical pods:

ObjectMeta:{history-limit-4-deploy  e2e-test-cli-deployment-47zjz /api/v1/namespaces/e2e-test-cli-deployment-47zjz/pods/history-limit-4-deploy dfcf8257-6df9-4356-9dad-62e2838d1017
ObjectMeta:{history-limit-4-deploy  e2e-test-cli-deployment-47zjz /api/v1/namespaces/e2e-test-cli-deployment-47zjz/pods/history-limit-4-deploy dfcf8257-6df9-4356-9dad-62e2838d1017

from https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/785/pull-ci-openshift-cluster-network-operator-master-e2e-ovn-hybrid-step-registry/1304878899443798016

but also the same is in the others,
Comment 6 zhou ying 2020-09-18 11:41:33 UTC 
Checked from https://search.ci.openshift.org/?search=r+persist+more+old+deployments+than+acceptable+after+being+observed+by+the+con&maxAge=48h&context=1&type=bug%2Bjunit&name=&maxMatches=5&maxBytes=20971520&groupBy=job . Can't see the same issue , will move to verified status.
Comment 9 errata-xmlrpc 2020-10-27 16:31:35 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196