Bug 1871954
Summary: | incomplete DeepCopy implementation for AWSProviderSpec objects | ||
---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Joel Diaz <jdiaz> |
Component: | Cloud Credential Operator | Assignee: | Joel Diaz <jdiaz> |
Status: | CLOSED ERRATA | QA Contact: | wang lin <lwan> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 4.6 | CC: | lwan |
Target Milestone: | --- | ||
Target Release: | 4.6.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-10-27 16:31:43 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Joel Diaz
2020-08-24 16:56:04 UTC
Hi, Joel. Could you tell me how to create DeepCopy from an AWSProviderSpec? There are already test cases to cover the DeepCopy() ( https://github.com/openshift/cloud-credential-operator/blob/master/pkg/apis/cloudcredential/v1/aws_manual.deepcopy_test.go#L171-L178 ). You could follow along with that pattern, but since the tests are already written, I would suggest a more high-level testing to make sure nothing broke in the process. Specifically, testing around CredentialsRequests with conditions defined. Making sure the AWS Users/Policies match what is specified in the CredentialsRequest. this won't influence CredentialsRequests. test payload:4.6.0-0.nightly-2020-08-31-194600 steps: 1.create CR with policyCondition like below: ################## spec: providerSpec: apiVersion: cloudcredential.openshift.io/v1 kind: AWSProviderSpec statementEntries: - action: - iam:CreateServiceLinkedRole effect: Allow policyCondition: StringEquals: iam:AWSServiceName: replication.dynamodb.amazonaws.com resource: '*' ##################### 2.check user/policy on aws, the policy is the same as i defined Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:4196 |