Bug 1872125

Summary: DeviceMechanicalProperties does not take effect when create localvolumeset instance from web console
Product: OpenShift Container Platform Reporter: Chao Yang <chaoyang>
Component: Console Storage PluginAssignee: Ankush Behl <anbehl>
Status: CLOSED ERRATA QA Contact: Chao Yang <chaoyang>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.6CC: aos-bugs, chuffman, hekumar, nthomas, sapillai
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 16:32:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chao Yang 2020-08-25 06:52:40 UTC
Description of problem:
DeviceMechanicalProperties does not take effect when create localvolumeset instance from web console

Version-Release number of selected component (if applicable):
local-storage-operator.4.6.0-202008210209.p0
4.6.0-0.nightly-2020-08-23-214712

How reproducible:
Always

Steps to Reproduce:
1.Deploy local-storage-operator
2.Create localvolumeset from web console, choose disk type as "SSD/NVMe"
3.Check the localvolumeset yaml file, `DeviceMechanicalProperty` does not generated into the yaml file.
spec:
  deviceInclusionSpec:
    deviceTypes:
    - disk
    minSize: 0Ti
  nodeSelector:
    nodeSelectorTerms:
    - matchExpressions:
      - key: kubernetes.io/hostname
        operator: In
        values:
        - ip-10-0-157-81
        - ip-10-0-173-172
        - ip-10-0-205-197


Actual results:
`DeviceMechanicalProperty` does not generate when create localvolumeset instance from webconsole

Expected results:
`DeviceMechanicalProperty` should be added into localvolumeset instance from webconsole

Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:

Comment 2 Santosh Pillai 2020-09-01 05:59:28 UTC
It should be `DeviceMechanicalProperties` instead of `DeviceMechanicalProperty`. Changes needed in UI, CSV-example, and openshift-enhancements.

Comment 5 Neha Gupta 2020-09-02 02:45:14 UTC
@chuffman This needs to be fixed in UI as well along with csv. Each should be tracked in separate bugzilla.

Comment 6 Santosh Pillai 2020-09-02 03:05:05 UTC
CSV issue is being tracked here - https://bugzilla.redhat.com/show_bug.cgi?id=1874695

Comment 9 Chao Yang 2020-09-08 09:06:41 UTC
oc get localvolumeset lvs-disk -o json | jq .spec.deviceInclusionSpec
{
  "deviceMechanicalProperties": [
    "NonRotational"
  ],
  "deviceTypes": [
    "disk"
  ],
  "minSize": "2Gi"
}

Comment 12 errata-xmlrpc 2020-10-27 16:32:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196