Bug 1872251

Summary:	[aws-ebs-csi-driver] Verify job in CI doesn't check for vendor dir sanity
Product:	OpenShift Container Platform	Reporter:	Fabio Bertinatto <fbertina>
Component:	Storage	Assignee:	Christian Huffman <chuffman>
Storage sub component:	Operators	QA Contact:	Qin Ping <piqin>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	aos-bugs, hekumar, jsafrane
Version:	4.6
Target Milestone:	---
Target Release:	4.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-24 15:16:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabio Bertinatto 2020-08-25 09:38:42 UTC

Description of problem:

Verify job doesn't check if vendor directory was updated correctly. This is a problem because upstream doesn't have a vendor directory, and usually after every rebase the go.mod file changes. This breaks our CI and we don't notice it.

How reproducible:

Always.

Steps to Reproduce:
1. Update go.mod without running "go mod vendor"
2. Submit the changes to openshift/aws-ebs-csi-driver
2. Verify job will pass

Actual results:
Verify job in CI will pass.

Expected results:
Verify job detects there are inconsistencies in vendor dir and fail.

Comment 2 Christian Huffman 2020-09-03 18:53:26 UTC

The following PRs were submitted:

- https://github.com/openshift/aws-ebs-csi-driver/pull/166 - introduces the changes in the aws-ebs-csi-driver repo.
- https://github.com/openshift/release/pull/11615 - introduces the change in the release repo.

Comment 15 Qin Ping 2020-12-14 03:19:35 UTC

From log: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_aws-ebs-csi-driver/172/pull-ci-openshift-aws-ebs-csi-driver-master-verify/1336872009929330688/artifacts/build-logs/src.log, we can see vendor dir sanity is checked and passed.

Comment 18 errata-xmlrpc 2021-02-24 15:16:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633