Bug 187235

Summary:	Review Request: ices - icecast streaming source client
Product:	[Fedora] Fedora	Reporter:	Andreas Thienemann <andreas>
Component:	Package Review	Assignee:	Matt Domsch <matt_domsch>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Keywords:	Reopened
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-04-24 10:45:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Andreas Thienemann 2006-03-29 14:05:36 UTC

Spec Name or Url: http://home.bawue.net/~ixs/ices/ices.spec
SRPM Name or Url: http://home.bawue.net/~ixs/ices/ices-2.0.1-2.src.rpm
Description:
IceS is a source client for a streaming server. The purpose of this client is
to provide an audio stream to a streaming server such that one or more
listeners can access the stream. With this layout, this source client can be
situated remotely from the icecast server.

Comment 1 Andreas Thienemann 2006-03-29 14:11:55 UTC

FYI:
rpmlint returns the following warnings and errors:

W: ices conffile-without-noreplace-flag /etc/logrotate.d/ices
E: ices non-standard-gid /var/log/ices ices
E: ices non-standard-dir-perm /var/log/ices 0770

The warning shouldn't be a problem, and the errors can be ignored. ices is
running under the userid ices and therefore the logdir must belong to another
user. Perms are set accordingly.

Comment 2 Matt Domsch 2006-04-23 18:38:25 UTC

looks quite good (nice cleanup from my attempt last fall!).  A few nits which
can be fixed at CVS checkin time:

Please chkconfig --add only on initial install, not upgrade.
%post
if [ $1 = 1 ]; then
    /sbin/chkconfig --add ices
fi

config(noreplace) the logrotate file:
%config(noreplace) %{_sysconfdir}/logrotate.d/ices



APPROVED.

Comment 3 Andreas Thienemann 2006-04-24 10:45:06 UTC

Thx. Package has been imported into cvs.