Bug 1872435

Summary: disableAllDefaultSources ignores new redhat-operators-appregistry (Red Hat Operators AppRegistry)
Product: OpenShift Container Platform Reporter: Simone Tiraboschi <stirabos>
Component: OLMAssignee: Evan Cordell <ecordell>
OLM sub component: OLM QA Contact: Jian Zhang <jiazha>
Status: CLOSED NOTABUG Docs Contact:
Severity: unspecified    
Priority: unspecified CC: dollierp
Version: 4.6   
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-26 07:38:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1871234    

Description Simone Tiraboschi 2020-08-25 17:34:34 UTC
Description of problem:
disableAllDefaultSources ignores new redhat-operators-appregistry (Red Hat Operators AppRegistry).

Example:
[cnv-qe-jenkins@cdi-nightly-m7wcp-executor ~]$ oc get catalogsource -A
NAMESPACE               NAME                           DISPLAY                         TYPE   PUBLISHER   AGE
openshift-marketplace   certified-operators            Certified Operators             grpc   Red Hat     4m23s
openshift-marketplace   community-operators            Community Operators             grpc   Red Hat     4m23s
openshift-marketplace   redhat-marketplace             Red Hat Marketplace             grpc   Red Hat     4m23s
openshift-marketplace   redhat-operators               Red Hat Operators               grpc   Red Hat     4m23s
openshift-marketplace   redhat-operators-appregistry   Red Hat Operators AppRegistry   grpc   Red Hat     43m


[cnv-qe-jenkins@cdi-nightly-m7wcp-executor ~]$ oc patch operatorhub.config.openshift.io/cluster -p='{"spec":{"disableAllDefaultSources":true}}' --type=merge
operatorhub.config.openshift.io/cluster patched

[cnv-qe-jenkins@cdi-nightly-m7wcp-executor ~]$ oc get catalogsource -A
NAMESPACE               NAME                           DISPLAY                         TYPE   PUBLISHER   AGE
openshift-marketplace   redhat-operators-appregistry   Red Hat Operators AppRegistry   grpc   Red Hat     43m

[cnv-qe-jenkins@cdi-nightly-m7wcp-executor ~]$ oc patch operatorhub.config.openshift.io/cluster -p='{"spec":{"disableAllDefaultSources":false}}' --type=merge
operatorhub.config.openshift.io/cluster patched

[cnv-qe-jenkins@cdi-nightly-m7wcp-executor ~]$ oc get catalogsource -A
NAMESPACE               NAME                           DISPLAY                         TYPE   PUBLISHER   AGE
openshift-marketplace   certified-operators            Certified Operators             grpc   Red Hat     4s
openshift-marketplace   community-operators            Community Operators             grpc   Red Hat     3s
openshift-marketplace   redhat-marketplace             Red Hat Marketplace             grpc   Red Hat     3s
openshift-marketplace   redhat-operators               Red Hat Operators               grpc   Red Hat     3s
openshift-marketplace   redhat-operators-appregistry   Red Hat Operators AppRegistry   grpc   Red Hat     43m


Version-Release number of selected component (if applicable):
4.6.0-fc.0

How reproducible:
100%

Steps to Reproduce:
1. run `oc patch operatorhub.config.openshift.io/cluster -p='{"spec":{"disableAllDefaultSources":true}}' --type=merge`
2. look for redhat-operators-appregistry
3.

Actual results:
redhat-operators-appregistry is not affected

Expected results:
redhat-operators-appregistry is handled as other default sources

Additional info:
It makes testing layered product more complex due to conflicts like:
> E0824 21:13:48.064507       1 queueinformer_operator.go:290] sync "openshift-cnv" failed: found more than one head for channel
> I0824 21:13:48.064790       1 event.go:278] Event(v1.ObjectReference{Kind:"Namespace", Namespace:"", Name:"openshift-cnv", UID:"48083152-a112-428a-9fae-6b9636a65c4a", APIVersion:"v1", ResourceVersion:"182005", FieldPath:""}): type: 'Warning' reason: 'ResolutionFailed' found more than one head for channel

Comment 1 Denis Ollier 2020-08-26 07:38:47 UTC
I am the one who created and enabled redhat-operators-appregistry to be able to install the local-storage-operator.

It is not managed by the OperatorHub, hence it's not an OLM issue.